Advanced Pull Request Tasks

Tips for pull requests

Before Pushing

Choose clever PR and commit messages

While it may be now obvious to you what 'crash issue' means, to help future hackers it'll be more clever to rename commit title to "Fix crash when opening new book with open dialogs " and in the commit message backreference the previous commit e.g. "fix crash similar to 4cca84bb3"

Applying Requested Changes

Apply PR on another branch

It is not completely necessary to close and open a new PR. To rebase on maint, you could modify your branch (rebase to maint), force-push, and edit the github PR base by clicking Edit after the base title.