2024-05-09 GnuCash IRC logs
00:43:41 *** arahael has quit IRC
01:27:58 *** fell has quit IRC
01:29:17 *** fell has joined #gnucash
01:29:18 *** ChanServ sets mode: +o fell
05:47:35 *** fell_laptop has joined #gnucash
05:47:35 *** fell has quit IRC
05:47:36 *** ChanServ sets mode: +o fell_laptop
07:05:26 *** chris has joined #gnucash
07:05:26 *** ChanServ sets mode: +v chris
07:05:26 *** gncbot sets mode: +o chris
07:06:36 <chris> Simon: if you can test #1936 for me I'll merge it in!
07:10:33 <chris> even better, if you could write the (failing) test into gnc-commodities.cpp to prove the fix is correct
07:21:27 <Simon> I had a look at the test cases but couldn't find anything that used an unknown source at all
07:22:01 <Simon> it really is simply taking the gnc_quote_src* of the first unknown source and checking that that hasn't changed after adding more
07:22:25 <Simon> but it's one of those things that becomes awkward to unit test
07:23:18 <Simon> because you could change the implementation so that it gives out something temporary like c_str(), which could be different each time you access a quote
07:39:53 <Simon> chris: yes, #1936 works
07:42:20 <Simon> chris: you have an unrelated commit in that PR
07:43:00 *** chris has quit IRC
08:27:49 *** chris has joined #gnucash
08:27:49 *** ChanServ sets mode: +v chris
08:27:49 *** gncbot sets mode: +o chris
08:36:32 <chris> Simon: for testing gnc-commodities.cpp I was thinking along the lines of "store the c_str() pointer, add a few thousand unknown quote_sources, and check the original pointer is still intact!"
09:10:20 <chris> Simon: #1936 now has the test I mentioned, failing and passing as expected ^_^
09:10:38 *** fell_laptop has quit IRC
09:11:51 <Simon> Don't do that
09:11:57 *** fell_laptop has joined #gnucash
09:11:58 *** ChanServ sets mode: +o fell_laptop
09:12:10 <Simon> Retrieve the pointer to the quote source and compare it with the previous one
09:12:50 <Simon> Comparing strings proves nothing conclusively because that particular allocation could survive
09:21:54 <chris> lol
11:52:05 *** chris has quit IRC
12:10:26 *** FeuerwehrMichael has joined #gnucash
12:10:26 *** ChanServ sets mode: +v FeuerwehrMichael
12:11:39 *** FeuerwehrMichael has quit IRC
12:11:56 *** FeuerwehrMichael has joined #gnucash
12:11:56 *** ChanServ sets mode: +v FeuerwehrMichael
12:13:52 *** FeuerwehrMichael has quit IRC
13:54:25 *** nick1 has joined #gnucash
13:55:11 *** nick1 has quit IRC
14:27:11 *** phebus has quit IRC
14:38:10 *** phebus has joined #gnucash
14:38:10 *** ChanServ sets mode: +v phebus
17:05:04 *** russ2242 has joined #gnucash
17:14:59 *** russ2242 has left #gnucash
17:15:47 *** russ has joined #gnucash
17:16:19 *** russ has quit IRC
17:17:54 *** russ has joined #gnucash
17:18:18 *** russ has left #gnucash
17:23:16 *** russ has joined #gnucash
17:23:16 *** ChanServ sets mode: +v russ
17:57:18 <russ> Trying to setup gnucash Windows build on 5.6-stable: setup-mingw64.ps1 runs and installs a lot of ming packages, the public signing key, but then just hangs at "updating trust database ..." and never completes. Neither the jhbuild or gnucash-on-windows is present. I'm not adept at PS script debugging. Is this failure mode familiar to anyone?
18:03:04 *** fell_laptop is now known as fell
18:14:55 *** warlord has quit IRC
19:39:34 *** chris has joined #gnucash
19:39:35 *** ChanServ sets mode: +v chris
19:39:35 *** gncbot sets mode: +o chris
20:00:02 *** raghukamath has quit IRC
20:09:31 *** raghukamath has joined #gnucash
20:09:32 *** ChanServ sets mode: +v raghukamath
21:01:52 *** chris has quit IRC