2023-01-23 GnuCash IRC logs
00:02:07 *** gas has joined #gnucash
00:07:18 *** ChanServ sets mode: +v gas
00:23:12 *** gas is now known as klagor
00:25:37 *** klagor has quit IRC
00:26:00 *** gas has joined #gnucash
00:31:52 *** gas is now known as klagor
00:37:38 *** chris has joined #gnucash
00:37:38 *** ChanServ sets mode: +v chris
00:37:42 *** gncbot sets mode: +o chris
00:39:43 <chris> jralls/warlord: IMHO gnc_commodity_compare has a glaring bug O_o it returns 0/1 instead of -1/0/1 as is expected e.g. gnc-pricedb.c#L1394
00:52:16 *** klagor has quit IRC
00:59:36 *** gas has joined #gnucash
01:03:57 *** gas has quit IRC
01:30:06 *** gandalf has joined #gnucash
01:34:09 *** gandalf1 has joined #gnucash
01:34:37 *** gandalf has quit IRC
01:34:37 *** gandalf1 is now known as gandalf
01:49:56 *** fell has quit IRC
01:51:16 *** fell has joined #gnucash
01:51:16 *** ChanServ sets mode: +o fell
02:11:03 *** gandalf1 has joined #gnucash
02:11:31 *** gandalf has quit IRC
02:11:31 *** gandalf1 is now known as gandalf
02:19:07 *** Aussie_matt has joined #gnucash
02:59:32 *** gandalf1 has joined #gnucash
02:59:59 *** gandalf has quit IRC
03:00:00 *** gandalf1 is now known as gandalf
03:04:52 <chris> jralls: s/return 1/return g_strcmp0 (gnc_commodity_get_fullname (a), gnc_commodity_get_fullname (b));
03:35:58 *** gandalf1 has joined #gnucash
03:36:25 *** gandalf has quit IRC
03:36:25 *** gandalf1 is now known as gandalf
04:12:11 *** gandalf1 has joined #gnucash
04:13:38 *** gandalf has quit IRC
04:13:38 *** gandalf1 is now known as gandalf
04:49:14 *** gandalf1 has joined #gnucash
04:49:41 *** gandalf has quit IRC
04:49:41 *** gandalf1 is now known as gandalf
05:23:47 *** gandalf1 has joined #gnucash
05:24:15 *** gandalf has quit IRC
05:24:15 *** gandalf1 is now known as gandalf
05:34:25 *** gandalf has quit IRC
05:34:48 *** gandalf has joined #gnucash
06:36:46 *** gandalf1 has joined #gnucash
06:37:13 *** gandalf has quit IRC
06:37:13 *** gandalf1 is now known as gandalf
07:21:08 <warlord> chris, g_strcmp0() will return -1/0/1
07:28:45 *** Unhammer has quit IRC
07:43:22 *** Unhammer has joined #gnucash
09:19:02 <fell> I wonder if our menu entry page setup is obsolete as it became a tab in the Print dialog.
09:40:31 *** gandalf1 has joined #gnucash
09:40:33 *** Aussie_matt has quit IRC
09:40:58 *** gandalf has quit IRC
09:40:58 *** gandalf1 is now known as gandalf
10:00:53 *** gjanssens has joined #gnucash
10:00:53 *** ChanServ sets mode: +o gjanssens
10:21:03 *** gandalf1 has joined #gnucash
10:21:30 *** gandalf has quit IRC
10:21:31 *** gandalf1 is now known as gandalf
11:00:36 *** gandalf1 has joined #gnucash
11:01:04 *** gandalf has quit IRC
11:01:04 *** gandalf1 is now known as gandalf
11:08:55 *** gjanssens has quit IRC
11:14:31 *** ArtGravity has joined #gnucash
11:14:31 *** ChanServ sets mode: +v ArtGravity
11:37:27 *** gjanssens has joined #gnucash
11:37:27 *** ChanServ sets mode: +o gjanssens
12:55:01 *** gandalf1 has joined #gnucash
12:55:28 *** gandalf has quit IRC
12:55:28 *** gandalf1 is now known as gandalf
13:01:33 *** palerider has joined #gnucash
13:03:25 *** palerider has left #gnucash
13:05:29 *** gjanssens has quit IRC
13:33:55 *** gandalf1 has joined #gnucash
13:34:23 *** gandalf has quit IRC
13:34:23 *** gandalf1 is now known as gandalf
14:11:43 <jralls> fell, assuming you mean the print report dialog, that's WebKit's print dialog and it has its own Page Setup tab: https://imgur.com/a/jYG1jtc
14:15:16 <jralls> chris, The two calls in compare_prices_by_commodity_date are the only ones where a < return would matter, the other two are just using it (indirectly via gnc_commodity_compare_void) as an equality check.
14:21:49 <jralls> compare_prices_by_commodity_date is used only once in gnc_pricedb_process_removal_list where it sorts the list of all prices by commodity and date and deletes all but the most recent price for each commodity. In that case the sort just needs to be stable; it doesn't need to be in any particular order that might make sense to humans, so sorting by GUID makes more sense: It's two uint64_t compares instead of an arbitrary nu
14:21:50 <jralls> mber of uint8_t ones, and it's possible that there could be two commodities in different namespaces with the same full name or mnemonic.
14:29:32 *** gandalf1 has joined #gnucash
14:29:59 *** gandalf has quit IRC
14:29:59 *** gandalf1 is now known as gandalf
14:30:06 <jralls> warlord, were you able to find linas's phone number?
14:57:34 *** ArtGravity has quit IRC
14:58:16 *** gjanssens has joined #gnucash
14:58:16 *** ChanServ sets mode: +o gjanssens
14:58:21 *** gandalf1 has joined #gnucash
14:58:48 *** gandalf has quit IRC
14:58:48 *** gandalf1 is now known as gandalf
15:22:36 *** NoobAlice has joined #gnucash
15:22:36 *** ChanServ sets mode: +v NoobAlice
15:34:24 *** gandalf1 has joined #gnucash
15:34:52 *** gandalf has quit IRC
15:34:53 *** gandalf1 is now known as gandalf
15:50:46 *** gjanssens has quit IRC
16:01:27 *** gandalf1 has joined #gnucash
16:01:54 *** gandalf has quit IRC
16:01:54 *** gandalf1 is now known as gandalf
16:23:31 *** gandalf has quit IRC
16:25:09 *** warlord has quit IRC
16:31:29 *** warlord has joined #gnucash
16:48:05 *** ChanServ sets mode: +qo warlord warlord
17:32:55 *** ArtGravity has joined #gnucash
17:32:55 *** ChanServ sets mode: +v ArtGravity
17:50:08 *** phebus has quit IRC
17:59:20 *** phebus has joined #gnucash
17:59:20 *** ChanServ sets mode: +v phebus
18:26:47 *** Aussie_matt has joined #gnucash
19:38:07 *** ArtGravity has quit IRC
20:25:24 <chris> jralls: I'll leave the gnc_commodity_compare to you...
20:25:46 <jralls> chris, OK.
23:13:43 *** NoobAlice has quit IRC