2022-05-05 GnuCash IRC logs
00:53:42 *** sbluhm has joined #gnucash
01:08:50 *** storyjesse has joined #gnucash
01:51:06 *** fell has quit IRC
01:51:29 *** fell has joined #gnucash
01:51:29 *** ChanServ sets mode: +o fell
01:58:31 *** fell has quit IRC
01:59:50 *** fell has joined #gnucash
01:59:50 *** ChanServ sets mode: +o fell
02:41:04 *** tomk_dk has joined #gnucash
03:05:27 *** tomk_dk1 has joined #gnucash
03:05:52 *** tomk_dk has quit IRC
03:05:52 *** tomk_dk1 is now known as tomk_dk
03:17:15 *** tomk_dk has quit IRC
03:31:43 *** tomk_dk has joined #gnucash
03:39:02 *** gjanssens has joined #gnucash
03:39:02 *** ChanServ sets mode: +o gjanssens
03:59:27 *** lagash has quit IRC
03:59:41 *** lagash has joined #gnucash
04:02:08 *** jmdaemon has quit IRC
04:11:10 *** storyjesse has quit IRC
04:33:33 *** storyjesse has joined #gnucash
05:07:45 *** tomk_dk has quit IRC
06:38:30 *** Aussie_matt has joined #gnucash
07:44:12 *** warlord has joined #gnucash
07:44:42 *** sbluhm has quit IRC
07:44:42 *** ChanServ sets mode: +qo warlord warlord
08:39:30 *** Jimraehl1 has joined #gnucash
08:49:01 *** Piko has quit IRC
09:21:39 *** Treasurer501c3 has joined #gnucash
09:24:56 *** Piko has joined #gnucash
09:28:57 *** Treasurer501c3 has quit IRC
09:43:24 *** Aussie_matt has quit IRC
10:12:05 *** storyjesse has quit IRC
10:42:09 *** Vafa has joined #gnucash
10:42:09 *** ChanServ sets mode: +v Vafa
11:22:34 *** fell has quit IRC
11:22:53 *** fell has joined #gnucash
11:22:53 *** ChanServ sets mode: +o fell
11:52:31 *** Piko has quit IRC
12:07:36 *** guak has joined #gnucash
12:09:13 *** bertbob has quit IRC
12:23:48 *** bertbob has joined #gnucash
12:23:48 *** ChanServ sets mode: +v bertbob
12:26:49 *** bertbob has quit IRC
12:57:11 *** jralls_afk is now known as jralls
12:58:52 *** bertbob has joined #gnucash
12:58:52 *** ChanServ sets mode: +v bertbob
13:00:11 *** jmdaemon has joined #gnucash
13:06:10 *** sbluhm has joined #gnucash
13:13:27 <jralls> chris: You must be *very careful* with std::optional. Using operator->() on one that doesn't have a value is UB. https://en.cppreference.com/w/cpp/language/ub
13:14:59 <jralls> chris, you're also used std::vector::at() outside of a try block. at() will throw if the index is out of range.
13:51:11 *** sbluhm has quit IRC
14:05:15 *** sbluhm has joined #gnucash
14:32:20 *** gjbott has joined #gnucash
14:34:38 *** gjbott_ has quit IRC
15:54:45 *** sbluhm has quit IRC
15:58:34 *** warlord has quit IRC
16:11:16 *** chf has quit IRC
16:13:44 *** chf has joined #gnucash
16:23:36 *** gjanssens has quit IRC
16:38:52 *** tj123 has quit IRC
18:42:16 *** BitViper has quit IRC
19:06:47 *** Vafa has quit IRC
19:31:57 *** fell has quit IRC
19:32:13 *** fell has joined #gnucash
19:32:13 *** ChanServ sets mode: +o fell
20:22:15 <chris> jralls: agree; these risks existed prior to using std::optional
20:22:47 <jralls> chris, no, the risk before is crashing due to a null check. UB is worse than crashing.
20:23:28 <jralls> s/null check/null dereference/
20:26:02 <jralls> Besides, this is all brand-new code. No legacy excuses! ;-)
20:33:34 *** guak has quit IRC
21:04:11 <chris> ok did the deed