2022-03-29 GnuCash IRC logs

01:07:15 *** sbluhm has joined #gnucash
01:23:49 *** frakturfreak1 has quit IRC
01:26:00 *** fell has quit IRC
01:26:49 *** fell has joined #gnucash
01:26:49 *** ChanServ sets mode: +o fell
01:37:57 *** frakturfreak1 has joined #gnucash
02:23:43 *** tj123_ has quit IRC
02:23:54 *** tj123_ has joined #gnucash
02:30:45 *** raeburn has quit IRC
02:42:04 *** tj123_ has quit IRC
02:42:21 *** tj123_ has joined #gnucash
02:50:03 *** Hamaryns has joined #gnucash
02:50:03 *** ChanServ sets mode: +v Hamaryns
02:50:18 *** Hamaryns has quit IRC
02:50:22 *** Hamaryns has joined #gnucash
02:50:22 *** ChanServ sets mode: +v Hamaryns
02:55:26 *** gjanssens has joined #gnucash
02:55:26 *** ChanServ sets mode: +o gjanssens
03:28:02 *** bertbob has quit IRC
03:29:26 *** bertbob has joined #gnucash
03:29:26 *** ChanServ sets mode: +v bertbob
03:41:40 *** bertbob has quit IRC
03:42:59 *** bertbob has joined #gnucash
03:43:00 *** ChanServ sets mode: +v bertbob
04:02:11 *** bertbob has quit IRC
04:14:48 *** bertbob has joined #gnucash
04:14:49 *** ChanServ sets mode: +v bertbob
04:16:39 <fell> jralls: Template:Macos Downloads calls {{MacosPackage}}, {{Version}}. Because of SF's redirections I am not sure that it has really what you intended. It isthenused in MacOS/Quartz, MacOS and He/מקOS/קוורץ .
05:01:02 *** theofpa has joined #gnucash
05:18:56 *** tj123_ has quit IRC
05:19:14 *** tj123 has joined #gnucash
06:11:05 *** User has joined #gnucash
06:32:18 *** theofpa has quit IRC
06:50:44 *** tj123 has quit IRC
06:50:49 *** tj123 has joined #gnucash
07:01:49 *** Hamaryns has quit IRC
08:48:46 *** Jimraehl1 has joined #gnucash
09:01:15 *** sbluhm has quit IRC
09:12:30 *** Pegasus_RPG has quit IRC
09:27:15 *** McLANE has joined #gnucash
10:10:45 *** miklcct has quit IRC
10:10:52 *** miklcct has joined #gnucash
10:10:52 *** ChanServ sets mode: +v miklcct
10:58:16 *** Hamaryns has joined #gnucash
10:58:16 *** ChanServ sets mode: +v Hamaryns
10:59:00 *** Hamaryns has quit IRC
10:59:04 *** Hamaryns has joined #gnucash
10:59:04 *** ChanServ sets mode: +v Hamaryns
11:02:51 *** Pegasus_RPG has joined #gnucash
11:04:34 *** David has quit IRC
11:05:02 *** David has joined #gnucash
11:27:58 *** Pegasus_RPG has quit IRC
11:40:20 *** guak has joined #gnucash
11:42:50 *** Hamaryns has quit IRC
11:56:26 *** jralls_a_ has joined #gnucash
11:56:26 *** ChanServ sets mode: +o jralls_a_
11:58:26 *** jralls_afk has quit IRC
12:45:58 *** Pegasus_RPG has joined #gnucash
13:58:45 <AdrienM> chris, I filed https://bugs.gnucash.org/show_bug.cgi?id=798493 and didn't check the log here first to see your discussion on precision. Can Invoice Report just print what the invoice already stores? (note, this applies to both Quantity & Unit Price columns)
14:02:26 *** sbluhm has joined #gnucash
14:03:21 <fell> jralls_a_: to add Win & Doc versions just copyand adjust the macos row in https://wiki.gnucash.org/wiki/Release_Process#New_Packages. After saving you can set them.
14:11:07 *** kcin has joined #gnucash
14:19:12 *** kcin has quit IRC
14:47:53 *** raeburn has joined #gnucash
14:47:53 *** ChanServ sets mode: +v raeburn
15:07:52 <jralls_a_> AdrienM: Do you really want rational numbers (i.e. 1/2 instead of 0.50) printed on your invoice? That's how GnuCash stores numbers.
15:08:52 <AdrienM> In that thread I think one user requested just that. What does the invoice ledger view do?
15:09:31 <AdrienM> I suppose though that plenty would not want that. I'd say it depends on how they entered the data.
15:20:28 *** gjanssens has quit IRC
15:23:22 <jralls_a_> The ledger should display as a decimal with amounts rounded to the commodity's "fraction traded" value and prices to 1/100 of that.
15:23:42 *** jralls_a_ is now known as jralls
15:25:47 <jralls> Keep in mind that prices are best left to GnuCash to calculate: Put in the amount and the value and let GnuCash calculate the price. That prevents rounding issues.
16:01:22 *** Pegasus_RPG has quit IRC
16:25:41 *** sbluhm has quit IRC
16:30:37 *** sbluhm has joined #gnucash
16:45:46 *** Pegasus_RPG has joined #gnucash
17:15:41 *** ArtGravity has joined #gnucash
17:15:41 *** ChanServ sets mode: +v ArtGravity
17:28:22 *** sbluhm has quit IRC
18:10:34 *** User has quit IRC
19:05:44 *** Pegasus_RPG has joined #gnucash
19:11:25 *** McLANE has quit IRC
19:29:19 *** ArtGravity has quit IRC
20:44:16 *** chris has joined #gnucash
20:44:16 *** ChanServ sets mode: +v chris
20:44:16 *** gncbot sets mode: +o chris
20:44:37 <chris> jralls/AdrienM: unfortunately inputting 1/3 as an item quantity is recorded intenrally as 333333333/1000000000
20:45:29 *** tj123 has quit IRC
20:46:30 *** tj123 has joined #gnucash
20:48:50 <chris> qty != price != (amount|value)
20:52:58 <chris> gncLedgerModel.c#L279-282 - wrong
20:53:53 <chris> IMV price&quantity shouldn't be limited to commodity SCU
20:58:35 <chris> but no idea how to handle old such data
21:06:17 <chris> commenting out gncLedgerModel #274-282 seems to make it right. I'd argue 269-273 too.
21:11:03 <AdrienM> jralls, not sure I follow. On an invoice, the user puts a quantity and a unit price. Those can be more decimal digits than 2 and they stay that way. But print that invoice, and you get rounding/truncation sometimes to the point of wrong/useless info. That's the bug I filed.
21:12:08 <chris> it's not wrong, it's written with the most common use case of ordinary people using whole integer quantities. weird ones like to push boundaries.
21:17:34 <chris> Ok agree it's "wrong" because the edge cases of having fractional quantities are not handled well at all.
21:18:15 <AdrienM> I can't seem to find gncLedgerModel.c either my search-foo is bad, or I'm dense.
21:19:08 <AdrienM> chris, not just quantities. Unit Prices aren't printed correctly either. The invoice view does show and retain both correctly. It's just the report that mangles them.
21:19:13 <chris> gncEntryLedger.c sorry
21:19:37 <chris> s/gncLedgerModel.c/gncEntryLedger.c
21:19:45 <AdrienM> got it, thanks.
21:23:41 *** guak has quit IRC
21:25:24 <AdrienM> I see the problem you note at #269-272 (unit price), and 279-282 (quantity), but it looks like 274-277 is affecting the Discount cell, unless I'm reading that wrong. But there too, it wouldn't make much sense to see a 5% discount on a price of 0.0005 be reported as "0.00"
21:26:07 <chris> Maybe but what do you suggest is done about old data eg. 333333333/1000000000
21:26:38 <AdrienM> But now I'm stumped. How does the ledger not round or truncate to GNC_COMMODITY_MAX_FRACTION when it shows here it should be doing so?
21:27:50 <AdrienM> I really don't think the data, old or new is the issue, unless I'm misunderstanding how this works. The ledger view of the invoice is correct and retains the user's choice of precision. It is just the Invoice Report that does not.
21:28:53 <AdrienM> Is gncEntryLedger one of the modules called by invoice.scm? and not used for the invoice ledger view?
21:30:48 <chris> gncEntryLedger defines the invoice entry view. the price/qty/discount are fixed to commodity_max_fraction. the data is (IMHO incorrectly) stored with max_fraction. the invoice.scm reads from the data.
21:40:27 <AdrienM> Then how does the invoice entry view show greater precision than either commodity_max_fraction or the result of invoice.scm?
21:53:36 <AdrienM> I made a composite screenshot if it helps, but I'd figure the code is more important.
22:06:46 *** bertbob has quit IRC
22:07:57 *** bertbob has joined #gnucash
22:07:57 *** ChanServ sets mode: +v bertbob
23:33:17 *** tj123 has quit IRC