2021-08-21 GnuCash IRC logs
01:08:16 *** FH_thecat has quit IRC
01:17:35 *** fell has quit IRC
01:18:54 *** fell has joined #gnucash
01:18:55 *** ChanServ sets mode: +o fell
01:19:19 *** Mechtilde has joined #gnucash
01:22:59 *** frakturfreak2 has joined #gnucash
01:25:21 *** frakturfreak1 has quit IRC
01:46:56 *** Mechtilde has quit IRC
01:47:30 *** Mechtilde has joined #gnucash
01:51:15 *** Mechtilde has quit IRC
01:54:18 *** Mechtilde has joined #gnucash
02:22:06 *** FH_thecat has joined #gnucash
02:32:14 *** sbluhm has joined #gnucash
02:48:19 *** kcin has joined #gnucash
03:09:46 *** sbluhm has quit IRC
03:13:58 *** sbluhm has joined #gnucash
03:27:36 *** fabior has joined #gnucash
03:39:29 *** sbluhm has quit IRC
03:44:22 *** fabior has quit IRC
04:05:58 *** fabior has joined #gnucash
04:10:01 *** jeanl has quit IRC
04:24:48 *** User has joined #gnucash
05:22:26 *** qwer has quit IRC
05:23:58 *** jeanl has joined #gnucash
05:26:59 *** jeanl has quit IRC
06:10:13 *** joo has quit IRC
06:10:34 *** sbluhm has joined #gnucash
06:15:05 *** sbluhm has quit IRC
06:20:13 *** puck has quit IRC
06:20:20 *** puck has joined #gnucash
06:24:08 *** joo has joined #gnucash
06:24:08 *** ChanServ sets mode: +v joo
06:51:21 *** sbluhm has joined #gnucash
07:08:26 *** fabior has quit IRC
07:25:02 *** FH_thecat has quit IRC
07:26:28 *** FH_thecat has joined #gnucash
07:30:00 *** kcin1 has joined #gnucash
07:30:23 *** kcin has quit IRC
07:32:27 *** kcin1 is now known as kcin
07:34:04 *** fell has quit IRC
07:34:23 *** fell has joined #gnucash
07:34:24 *** ChanServ sets mode: +o fell
07:34:45 *** qwer has joined #gnucash
07:37:42 *** jeanl has joined #gnucash
07:40:43 *** jeanl has quit IRC
08:00:59 *** storyjesse has quit IRC
08:02:06 *** storyjesse has joined #gnucash
08:11:06 *** jeanl has joined #gnucash
08:14:06 *** jeanl has quit IRC
08:31:58 *** sbluhm has quit IRC
08:56:41 *** storyjesse1 has joined #gnucash
08:56:41 *** Mechtilde has quit IRC
08:57:05 *** storyjesse has quit IRC
08:57:05 *** storyjesse1 is now known as storyjesse
08:58:13 *** Mechtilde has joined #gnucash
09:15:53 *** Jimraehl1 has joined #gnucash
09:17:11 *** Jimraehl1 has left #gnucash
09:43:57 *** sbluhm has joined #gnucash
11:45:24 *** jeanl has joined #gnucash
11:46:12 *** kcin1 has joined #gnucash
11:46:36 *** kcin has quit IRC
11:48:40 *** kcin1 is now known as kcin
11:52:47 *** field^Zzz3 has joined #gnucash
11:57:27 *** sbluhm has quit IRC
12:09:05 *** sbluhm has joined #gnucash
12:10:05 <chris> jralls: this is probably obvious to you, further experiments with static char* and the *previous* window-main-summarybar.c whereby mnemonic pointer is stale -- the old pointer isn't overwritten which means the consequences of invalid read will be unreliable
12:10:08 <chris> https://pastebin.com/raw/AwRaDH9t
12:12:11 <chris> conclusion- some behaviours may be undetected until far in the future
12:19:35 *** sbluhm has quit IRC
12:46:03 <jralls_afk> chris, Yes, it's obvious, it's why https://github.com/Gnucash/gnucash/commit/c398bef59719c2c53ede8d4ca4d680ee48e613bf is necessary.
12:47:25 *** jeanl has quit IRC
12:49:08 <jralls_afk> Even the "immediate use" dictum for const variables backed by a function static like that is insufficient in multithreaded code though. It's arguable that it's better to take the performance hit and always allocate the return value instead.
13:36:59 *** sbluhm has joined #gnucash
13:51:57 *** field^Zzz3 has quit IRC
14:00:22 *** kcin1 has joined #gnucash
14:00:46 *** kcin has quit IRC
14:02:50 *** kcin1 is now known as kcin
14:43:06 *** FH_thecat has quit IRC
14:44:55 *** Mechtilde has quit IRC
15:06:59 *** sbluhm has quit IRC
15:12:17 *** sbluhm has joined #gnucash
15:18:21 *** guak has joined #gnucash
15:23:32 *** sbluhm has quit IRC
15:37:27 *** frakturfreak2 has quit IRC
15:39:40 *** storyjesse has quit IRC
15:43:47 *** violethaze74 has joined #gnucash
15:48:40 *** lmat has quit IRC
15:51:30 *** frakturfreak2 has joined #gnucash
15:51:39 *** lmat has joined #gnucash
16:47:10 *** jeanl has joined #gnucash
16:50:11 *** jeanl has quit IRC
17:01:10 *** kcin has quit IRC
17:35:06 *** User has quit IRC
17:56:37 *** violethaze74 has quit IRC
19:35:57 *** bertbob has quit IRC
19:39:42 *** bertbob has joined #gnucash
19:39:42 *** ChanServ sets mode: +v bertbob
20:06:27 <chris> jralls_afk: there's already performance hit because g_value_dup_string copies the string; the difference is the caller frees the string. There's a third approach: after retrieving kvp, we cache result in commodity->nice_symbol.
20:31:15 *** guak has quit IRC
20:48:50 *** jralls_afk is now known as jralls
20:51:12 <jralls> chris, that's not an alternative. Loading from KVP into a commodity member variable is, but I wasn't able to get you to understand how KVP works the last time.
20:52:23 *** jeanl has joined #gnucash
20:55:23 *** jeanl has quit IRC
23:18:44 <chris> jralls: I think https://github.com/christopherlam/gnucash/commit/ec40d3a2c42ed86919d38c2735905caf4bdf60df is the correct approach
23:19:31 <chris> hmm it'll hit kvp read whenever user_symbol is NULL