2019-02-23 GnuCash IRC logs

00:17:47 *** Aussie_matt has quit IRC
00:34:46 *** Aussie_matt has joined #gnucash
00:38:06 *** christopherlam[m] has joined #gnucash
00:39:26 *** christopherlam[m] has left #gnucash
00:45:42 *** Aussie_matt has quit IRC
01:31:42 *** Aussie_matt has joined #gnucash
01:49:01 *** fell has quit IRC
01:50:20 *** fell has joined #gnucash
01:56:40 *** Mechtilde has joined #gnucash
02:35:22 *** gjanssens has joined #gnucash
02:35:23 *** ChanServ sets mode: +o gjanssens
02:36:23 <gjanssens> .
02:43:42 *** gour has joined #gnucash
03:28:56 *** bertbob has quit IRC
03:32:55 *** bertbob has joined #gnucash
03:56:39 *** Mechtilde has quit IRC
03:58:39 *** Mechtilde has joined #gnucash
04:14:51 *** boldstripe has joined #gnucash
04:22:00 *** Aussie_matt has quit IRC
04:34:25 *** storyjesse has quit IRC
04:45:15 *** fabior has joined #gnucash
04:52:34 *** Aussie_matt has joined #gnucash
05:17:05 *** Mechtilde has quit IRC
05:32:59 *** Mechtilde has joined #gnucash
05:41:58 *** gour_ has joined #gnucash
05:44:04 *** gour has quit IRC
06:19:33 *** gncbot sets mode: +o fell
06:46:13 *** User__ has joined #gnucash
06:54:53 *** User__ has quit IRC
06:56:14 *** fabior has quit IRC
07:02:05 *** Mechtilde has quit IRC
07:02:18 *** Mechtilde has joined #gnucash
07:04:24 *** oozer has joined #gnucash
07:15:58 <chris> just throwing it out there... budget-barchart has options for barchart start/end date... these should be removed, and the budget-start-date & budget-periods being used to select dates instead. should this go into maint?
07:19:09 <chris> (any changes will be PR'd first)
07:39:29 *** Jimraehl1 has joined #gnucash
07:40:16 *** Jimraehl1 has left #gnucash
07:41:33 <gjanssens> chris: I would put that in master. Changing options/preferences/data models should be limited as much as possible in a stable release.
07:42:25 <chris> ok. i've done these changes in the chartjs PR, although I haven't quite separated them from chartjs changes.
07:59:55 *** jervin has joined #gnucash
08:02:03 *** boldstripe_ has joined #gnucash
08:02:17 *** boldstripe has quit IRC
08:02:17 *** boldstripe_ is now known as boldstripe
08:09:03 * chris finds gnufibux's code rather unsatisfactory ...
08:12:26 *** jervin has quit IRC
08:37:11 *** boldstripe_ has joined #gnucash
08:37:27 *** boldstripe has quit IRC
08:37:27 *** boldstripe_ is now known as boldstripe
08:40:24 *** nimish has joined #gnucash
08:49:35 <chris> so, I've run out of easy bugs to fix, and ideas how to move reports forward. many reports eg accounts-summary / budget use the *very* complicated and buggy html-acct-table toolkit to build account-table, and tbh I'd rather create from scratch than try to fix them. the ugly TB is one of them.
08:50:32 *** chris has quit IRC
08:50:32 <warlord> chris, go for it! :)
08:51:06 *** chris has joined #gnucash
08:51:41 <warlord> chris, go for it! :)
08:54:53 <gjanssens> ditto :)
08:55:10 <gjanssens> Targeting master of course...
08:55:26 <chris> do we really want to nuke the whole folder? :-O
08:55:36 *** Aussie_matt has quit IRC
08:55:42 <chris> scorched earth policy
08:56:06 <warlord> Hahaha
08:59:51 *** fabior has joined #gnucash
09:07:56 *** oozer has quit IRC
09:30:25 *** jervin has joined #gnucash
09:32:22 *** jervin has quit IRC
09:36:05 *** boldstripe has quit IRC
09:45:40 <chris> https://imgur.com/a/tRsFlUc would help the irc user from couple days ago
09:48:11 *** lmat has quit IRC
09:52:19 *** User__ has joined #gnucash
10:02:00 *** lmat has joined #gnucash
10:12:36 *** nimish has quit IRC
10:13:21 *** lmat has quit IRC
10:21:46 *** lmat has joined #gnucash
10:23:34 <fell> Ahh, my example from a moth ago. :-)
10:34:49 *** boldstripe has joined #gnucash
10:51:55 *** bertbob has quit IRC
10:54:26 *** bertbob has joined #gnucash
11:02:27 *** User__ has quit IRC
11:07:58 *** Musk_Nakamoto has quit IRC
11:19:54 *** Musk_Nakamoto has joined #gnucash
12:34:49 *** fabior has quit IRC
12:49:59 *** boldstripe has quit IRC
12:52:53 *** fabior has joined #gnucash
13:59:08 *** fabior has quit IRC
14:02:39 *** frakturfreak has joined #gnucash
14:34:39 <fell> I have a problem:
14:34:40 <fell> CMake Error at data/accounts/CMakeLists.txt:6 (add_subdirectory):
14:34:41 <fell> add_subdirectory given source "C" which is not an existing directory.
14:35:26 <fell> I did not touch the line with C, but added a line for hr below
14:36:23 <fell> The directory appears i the build dir but not in the tarball
14:38:01 *** bertbob has quit IRC
14:40:53 <frakturfreak> Wm clearly has lost it. And clearly hasn’t done everyday financial accounting for client vat returns. Does he think I’m living in Zimbabwe? What an idiot.
14:41:14 *** bertbob has joined #gnucash
14:41:56 <fell> frakturfreak, put him on your ignore list.
14:43:21 <frakturfreak> Yeah I’ve just answered him privately it becomes to stupid putting it on the list also I can just keep pressing space. No need for an ignore.
14:45:16 <fell> There are rare moments, where he has good argument, but to find them is like gold digging.
14:48:54 <frakturfreak> And I’m sure due to the harmonized vat laws there surely has to be something about using bank of england rates for converting to £.
14:50:47 <frakturfreak> Yeah I think if it’s technical there might be some things for him, i guess but not when it comes to the accounting/theoretical financial transactions part.
15:17:52 <gjanssens> fell: anywhere I can see your work so far to help debug the build error ?
15:18:19 <gjanssens> That is, have you pushed it to a private branch on your github repo ?
15:18:49 <fell> I never pushed there
15:19:30 <gjanssens> It's a handy way to share work in progres :)
15:21:40 <fell> I will read to set it up. (perhaps we should add a section to the Git wiki pag?
15:24:08 <gjanssens> perhaps
15:24:37 <gjanssens> fell: the way to set it up is to add an extra remote to your local git repository
15:24:50 <gjanssens> git remote add <name> <url>
15:25:11 <gjanssens> You can choose the name freely (I'm using gjgh as short for geertJanssens' github)
15:25:35 <gjanssens> The url can be copied from your github repository's main page
15:26:04 <gjanssens> (Under the "Clone or Download" button)
15:26:09 <gjanssens> Best is to use the git@xyz url
15:27:01 <gjanssens> Once you have added the remote this way (you can verify this with git remote -v) you can push branches to this location like
15:27:09 <gjanssens> git push <name> <branch>
15:27:34 *** bertbob has quit IRC
15:27:35 <gjanssens> With <name> the name you gave your remote and <branch> the branch you want to push there
15:31:58 <fell> connecting-to-github-with-ssh, I assume?
15:33:19 <gjanssens> fell: yes
15:34:45 <fell> That is the region in teh github section ofour wiki-page were I got lost: the different protocolls and security methods.
15:36:41 <gjanssens> Ok.
15:37:44 <gjanssens> There are two that are relevant: connection of ssh (urls that start with git@github.com:...) and connection over https (urls starting with https://github.com/...)
15:38:17 <gjanssens> The first should be used when you want write access, the second if read access is sufficient (or write access is not granted)
15:45:35 *** aoi has joined #gnucash
15:45:42 <gjanssens> In your specific case the url for your personal github repository is git@github.com:fellen/gnucash.git
15:49:11 <fell> I know my URL. ;-) but have to generate a key...
15:50:29 <gjanssens> Oh... Haven't you got one yet for pushing to code ?
15:50:45 <gjanssens> You could reuse that one
15:51:35 <fell> I thought it wouuld be better to have a different
15:54:09 <gjanssens> That's your decision to make :)
16:06:44 *** bertbob has joined #gnucash
16:11:11 *** aoi has quit IRC
16:18:12 <fell> verified gh's fingerprint, but failed auth ...
16:19:29 *** bertbob has quit IRC
16:19:33 <gjanssens> fell: did you add the public key in your github account ?
16:19:44 <fell> yes
16:20:04 <gjanssens> And did you configure ssh on your machine to use this key ?
16:20:08 <fell> It is an eclispe issue
16:20:21 <gjanssens> Ah, eclipse
16:20:32 *** oozer has joined #gnucash
16:20:50 <gjanssens> Perhaps you can try from the command line first, to reduce the possible points of failure
16:21:12 <gjanssens> Can you clone your github repo on the commandline ?
16:21:28 <gjanssens> (git clone git@github.com:fellen/gnucash.git)
16:23:47 <fell> delta compression ...
16:23:57 <fell> writing
16:25:53 <fell> has GH an update feature for the forks?
16:26:56 <gjanssens> The only way I know how to update is to push branches from your local repo
16:27:17 <gjanssens> Or drop the githhub fork and reclone it
16:27:21 <gjanssens> (refork)
16:27:39 <fell> That would have been faster
16:29:18 <fell> https://github.com/fellen/gnucash/tree/sr
16:31:09 <gjanssens> fell: thanks.
16:31:21 <gjanssens> The issue is in data/accounts/hr/CMakeLists.txt
16:31:41 <gjanssens> Line 23 should define HR_DIST instead of C_DIST
16:31:57 <fell> OIugh
16:32:29 *** aoi has joined #gnucash
16:33:46 <gjanssens> The good thing is you have your personal github repo configured now. You only have to do that once and you can reuse it in the future to share code.
16:34:38 <fell> The terrible thing will be to clean up wiki:Git ;-)
16:35:29 <fell> But at first I check wiki:
16:35:39 <fell> translation for the issue
16:35:42 *** aoi has quit IRC
16:37:24 <fell> The good news: I didn't follow my own instructions completely.
16:41:07 *** gour_ has quit IRC
16:55:48 *** tienne has joined #gnucash
16:58:42 *** Mechtilde has quit IRC
17:06:46 *** bertbob has joined #gnucash
17:26:21 *** bertbob has quit IRC
17:31:39 *** bertbob has joined #gnucash
17:39:30 <fell> I am just wondering, why PR#455 was not automactic closed. Probably because it was a merge of merge?
17:48:02 <gjanssens> fell: yes
17:48:18 <gjanssens> The PR is a merge attempt to maint.
17:48:35 <gjanssens> That means it ends in a merge commit on maint
17:48:59 <gjanssens> However what you did what merge it into a local branch in your repo and then you merged your branch into maint
17:49:26 <gjanssens> So that original merge commit the PR closing is triggered on never hit the maint branch
17:50:18 <fell> (which it was originally, but I was too lazy to redo the stuff after chris' commits)
17:50:52 <gjanssens> I think you could have rebased your branch onto current maint right before merging to avoid this
17:52:06 <fell> The merge was a few days ago. Then followed the adjustment of the cmake files and their documentation
17:53:25 <gjanssens> Yeah I understood that
17:53:46 <fell> I am still finding dead autotools in Translation :-(
17:54:02 * gjanssens quickly ran the experiment... a simple rebase would not have helped here
17:55:05 <gjanssens> To fix you would have had to reset your local maint back to before the merge commit, re-merge with origin/maint again and then cherry-pick or rebase your changes on top...
17:55:25 <gjanssens> Pretty advanced tweaking. I think what you did is good enough :)
17:56:15 <fell> I fear, he did not translate the windows installer because that moved in another repo
17:57:13 <fell> That is what I had done yesterday
17:57:50 <fell> But chris is always faster with commits. ;-)
17:58:04 <gjanssens> :D
17:58:49 <gjanssens> Well, if you know what to do the whole reset/merge/rebase takes half a minute
17:59:10 <gjanssens> And it's the last thing to do before the final push to origin
17:59:19 <gjanssens> But as I said, it's ok as is
17:59:37 <gjanssens> I don't want this to become a roadblock for contributions
18:04:44 <gjanssens> By the way, well done fell :)
18:05:24 <fell> Thanks to your eagle eyes ;-)
18:07:13 <gjanssens> Well, I have dabbled a lot in the CMakeList.txt files in the preparations for gnucash 3 so I had an idea where to look
18:08:10 <gjanssens> Unfortunately gnucash fails to build on my system now
18:08:19 <gjanssens> Some issue with gnc-version :(
18:08:31 <gjanssens> That's unrelated to your work though
18:08:34 <fell> rm build
18:08:45 <fell> I had the issue yesterday
18:09:18 <fell> seems to be the guile cache or similar
18:09:31 <gjanssens> Yes, I think so too
18:11:26 <fell> Probably it shold go in the release notes?
18:14:47 <gjanssens> It was a stale build artefact: ./_cmake_build/libgnucash/core-utils/CMakeFiles/gnc-core-utils.dir/swig-core-utils-guile.c.o
18:17:12 <gjanssens> It's a build system bug these files are not properly updated. And a make/ninja-build clean doesn't clear them out.
18:29:47 *** tienne has quit IRC
18:37:13 <gjanssens> fell: ftr https://bugs.gnucash.org/show_bug.cgi?id=796769
18:39:32 <fell> But it is from 2018-07-18
18:40:20 <gjanssens> fell: yes, but I believe it's the same issue, only for another exported symbol.
18:40:30 <fell> right
18:43:11 <fell> Also mentioned there: Are we still using gwengui?
18:44:55 <fell> Ah gwenhywfar from aqbanking
18:46:54 <fell> its gui to set up banking connections.
18:47:51 <gjanssens> Yeah, something like that. I don't use aqbanking, so that's a fuzzy area for me.
18:48:37 <chris> gjanssens #450 is slowly being pushed manually, project by project, and more tests being created meanwhile
18:49:36 <chris> the only strand remaining is the report.scm cleanup, and I just wished to make sure Gnufibux's tests are comprehensive (hint: they're not) before pushing the clean up through
19:42:22 <gjanssens> chris: ok. So I'll let you work that at your own pace.
19:42:38 <gjanssens> I just wasn't sure I had forgotten to close the PR or something...
19:47:09 *** gjanssens has quit IRC
20:36:38 *** Musk_Nakamoto has quit IRC
20:41:13 *** Musk_Nakamoto has joined #gnucash
20:52:42 *** Musk_Nakamoto has quit IRC
20:53:26 *** Aussie_matt has joined #gnucash
20:58:02 *** Musk_Nakamoto has joined #gnucash
21:01:53 *** Musk_Nakamoto has quit IRC
21:28:12 *** oozer has quit IRC
21:31:57 *** nimish has joined #gnucash
21:43:44 *** Musk_Nakamoto has joined #gnucash
22:06:48 *** Aussie_matt has quit IRC