2018-08-18 GnuCash IRC logs

00:31:14 *** Mechtilde has joined #gnucash
00:59:47 *** gour has joined #gnucash
01:14:48 *** Aussie_matt has quit IRC
01:15:05 *** harshitaneja_ has joined #gnucash
01:16:57 *** harshitaneja has quit IRC
01:17:27 *** harshitaneja_ is now known as harshitaneja
01:22:46 *** harshitaneja has quit IRC
01:23:12 *** harshitaneja_ has joined #gnucash
01:24:36 *** harshitaneja_ is now known as harshitaneja
01:25:12 *** fell has quit IRC
01:26:31 *** fell has joined #gnucash
01:31:58 *** Mechtilde has quit IRC
01:37:41 *** Mechtilde has joined #gnucash
01:39:19 *** puck_ has quit IRC
01:45:19 *** puck has joined #gnucash
01:51:12 *** gjanssens has joined #gnucash
01:51:12 *** ChanServ sets mode: +o gjanssens
01:51:21 <gjanssens> .
02:12:32 *** fell has quit IRC
02:38:19 *** puck is now known as puck_
02:47:41 *** O01eg has quit IRC
02:49:24 *** O01eg has joined #gnucash
03:02:37 *** fell has joined #gnucash
03:36:17 <Mechtilde> as a reminder: FROSCON (froscon.de) is next week in St. Augustin near Bonn/Germany
03:50:24 *** O01eg has quit IRC
03:56:37 *** fell has quit IRC
03:58:55 *** fell has joined #gnucash
04:00:50 *** fell has quit IRC
04:04:35 *** fell has joined #gnucash
04:08:48 *** jtaylor has joined #gnucash
04:18:49 *** boldstripe has joined #gnucash
04:21:23 *** jtaylor has quit IRC
04:24:16 *** jtaylor has joined #gnucash
04:26:44 *** jtaylor has quit IRC
04:27:52 *** jtaylor has joined #gnucash
04:28:06 *** jtaylor has joined #gnucash
04:29:38 *** boldstripe has quit IRC
04:31:30 *** harshitaneja has quit IRC
04:34:02 *** harshitaneja has joined #gnucash
04:39:35 *** jtaylor has quit IRC
04:48:25 *** jtaylor has joined #gnucash
05:08:24 *** jotrago1 has joined #gnucash
05:08:49 *** jotrago has quit IRC
05:08:49 *** jotrago1 is now known as jotrago
05:17:19 *** jotrago has quit IRC
05:17:23 *** jotrago has joined #gnucash
05:19:48 *** gncbot sets mode: +o fell
05:38:44 *** fabior has joined #gnucash
06:07:48 *** storyjesse has joined #gnucash
06:14:38 *** GabrieleV has joined #gnucash
06:19:09 *** GabrieleV has quit IRC
06:22:51 *** storyjesse has quit IRC
06:48:15 *** gjanssens has quit IRC
06:58:15 *** Jimraehl1 has joined #gnucash
07:02:03 *** Jimraehl1 has left #gnucash
07:02:23 *** gjanssens has joined #gnucash
07:02:23 *** ChanServ sets mode: +o gjanssens
07:02:45 *** oozer has joined #gnucash
07:15:33 *** sixwheeledbeast has quit IRC
07:25:02 *** sixwheeledbeast has joined #gnucash
07:25:30 *** fabior has quit IRC
08:44:17 *** oozer has quit IRC
08:59:59 *** phebus has quit IRC
09:01:39 *** phebus has joined #gnucash
09:46:58 <gjanssens> jralls: while formulating my answer to Bob in https://bugs.gnucash.org/show_bug.cgi?id=796812 I came across the time64CanonicalDayTime function
09:47:24 <gjanssens> It looks like this function returns date with the time part set to noon instead of 10:59
09:47:32 <gjanssens> And this function is still in use :(
09:47:54 <gjanssens> Shouldn't we align this with the rest or is there a good reason it's still working with noon ?
10:08:43 *** fell has quit IRC
10:11:30 *** fell has joined #gnucash
10:13:58 *** fabior has joined #gnucash
10:17:08 *** gour_ has joined #gnucash
10:19:10 *** gour has quit IRC
10:28:35 *** gour_ is now known as gour
10:44:32 *** fell has quit IRC
11:11:15 *** harshitaneja has quit IRC
11:31:40 *** fekepp has joined #gnucash
11:44:45 *** harshitaneja has joined #gnucash
11:48:01 *** fekepp has quit IRC
11:49:27 *** fabior has quit IRC
13:10:57 <jralls> gjanssens: I think time64CanonicalDayTime should return 10:59:59 and also renamed (along with a large chunk of the time API) to have a consistent naming scheme.
13:12:28 <jralls> gjanssens: I'm confused by your response on https://github.com/Gnucash/gnucash/pull/399. Do you mean that my comment was unclear?
13:18:28 *** Mechtilde has quit IRC
13:20:02 *** Mechtilde has joined #gnucash
13:27:25 <gjanssens> No, I meant to express that I do think we should update this particular case now already as I expect it will bite us in the future. Bob's time corrections are done in a separate function so we may miss this when we refactor gnc_entry_get_date.
13:28:22 <gjanssens> Doing it now already won't hurt IMO and will make sure it will be visible once we start with the refactoring.
13:29:01 <gjanssens> I just think that in a big refactoring we sometimes miss details such as the bug Bob intends to fix.
13:29:33 <gjanssens> His fix alone does work right now, I just worry if we don't make the time selection explicit now we risk getting the same bug reported in the future.
13:31:17 *** oozer has joined #gnucash
13:35:32 *** kus has joined #gnucash
13:36:37 <jralls> gjanssens: Actually there's already a gnc_date_edit_get_date_end() that operates directly on the struct tm returned by gnc_date_edit_get_date_internal. Using that would be both faster and more clear for later refactoring.
13:39:38 <gjanssens> Ah, I missed that and that's an even better suggestion for Bob. Will you inform him ?
13:48:28 <jralls> OK.
13:52:49 *** User has joined #gnucash
14:00:27 *** mdf has joined #gnucash
14:17:58 *** Mechtilde has quit IRC
14:44:47 *** fekepp has joined #gnucash
15:11:59 *** frakturfreak has joined #gnucash
15:14:44 *** User has quit IRC
16:10:21 *** fell has joined #gnucash
16:44:47 *** gour has quit IRC
17:17:43 *** gjanssens has quit IRC
17:18:57 *** kus has quit IRC
17:50:07 *** kus has joined #gnucash
17:52:56 *** User has joined #gnucash
17:56:00 *** User has quit IRC
18:00:29 *** sixwheeledbeast has quit IRC
18:00:48 *** sixwheeledbeast has joined #gnucash
18:29:13 *** bertbob has quit IRC
18:34:08 *** JayC has quit IRC
18:35:56 *** JayC has joined #gnucash
18:37:29 *** JayC has quit IRC
18:37:47 *** JayC has joined #gnucash
19:07:04 *** bertbob has joined #gnucash
19:10:10 *** bertbob has quit IRC
19:20:54 *** gncbot sets mode: +o fell
19:26:02 *** bertbob has joined #gnucash
19:35:04 *** fekepp has quit IRC
19:57:25 *** bertbob has quit IRC
20:03:49 *** bertbob has joined #gnucash
21:16:00 *** frakturfreak has quit IRC
21:17:20 *** frakturfreak has joined #gnucash
21:27:49 *** frakturfreak has quit IRC
21:28:46 *** frakturfreak has joined #gnucash
21:31:01 *** frakturfreak has quit IRC
21:38:04 *** Cuare has joined #gnucash
21:39:49 *** oozer has quit IRC
21:43:50 <fell> To lower the Schwelle
21:44:07 <fell> (wrong window)
21:46:42 <fell> To lower the barriers I just drafted https://wiki.gnucash.org/wiki/Simple_Patch. Jralls, do we want this?
22:12:49 *** bertbob has quit IRC
22:32:20 *** Cuare has quit IRC
22:43:13 *** bertbob has joined #gnucash
23:03:05 *** opteron has quit IRC
23:03:15 *** opteron has joined #gnucash
23:04:19 *** pilotauto has joined #gnucash
23:22:31 *** bertbob has quit IRC
23:41:39 *** fell has quit IRC
23:43:11 *** bertbob has joined #gnucash
23:44:02 *** Mechtilde has joined #gnucash