2018-05-23 GnuCash IRC logs

00:26:40 *** Agfarmer18 has quit IRC
00:51:25 *** Mechtilde has joined #gnucash
01:20:35 *** fell_afk has quit IRC
01:21:53 *** fell_afk has joined #gnucash
01:39:01 *** gour has joined #gnucash
01:39:34 *** eagles0513875 has quit IRC
01:40:32 *** eagles0513875 has joined #gnucash
01:41:15 *** Mechtilde has quit IRC
01:56:05 *** frakturfreak has quit IRC
02:10:49 *** frakturfreak has joined #gnucash
02:28:02 *** storyjesse has quit IRC
02:45:10 *** storyjesse has joined #gnucash
02:46:56 *** storyjesse has quit IRC
02:49:43 *** fekepp has joined #gnucash
03:00:25 *** harshitaneja has joined #gnucash
03:33:21 *** gjanssens has joined #gnucash
03:33:21 *** ChanServ sets mode: +o gjanssens
03:34:19 <gjanssens> .
03:39:52 *** jotrago has quit IRC
03:48:32 *** Mechtilde has joined #gnucash
04:12:29 *** Mechtilde has quit IRC
04:12:50 *** ncv has joined #gnucash
04:40:09 *** njonah has joined #gnucash
04:41:10 *** njonah has quit IRC
04:41:24 *** tms has quit IRC
05:03:09 *** pilotauto has quit IRC
05:09:19 *** tms has joined #gnucash
05:23:12 <gjanssens> jralls, warlord: I finally have some time now to look at the bugzilla migration. I'll add my thoughts here as I go along
05:23:56 <gjanssens> First thing: when clicking on the "Browse" button two products are presented: "GnuCash" and "TestProduct".
05:24:19 <gjanssens> Obviously the TestProduct is just that and will probably disappear when we go live.
05:25:06 <gjanssens> However as we host bugzilla at gnucash.org, it should be obvious the database is about gnucash.
05:25:42 <gjanssens> So perhaps we can reuse the product field for a more useful separation of bugs
05:26:32 <gjanssens> How about having "Gnucash" for that program, "Documentation" for all documentation related bugs and "Website" for our website related bugs
05:27:30 <gjanssens> Documentation and Website are currently components of gnucash so they would be moved.
05:29:45 <gjanssens> This split more or less follows the same separation as we have in git. If we take that as a guide we may also want an "OS integration" product covering issues specific to the Windows and OS X integration repos (gnucash-on-windows and gnucash-on-osx)
05:30:26 <gjanssens> The "OS Integration" could have a Windows and an OS X/Quarz (or however it's spelled these days) component
05:32:50 <gjanssens> Planning ahead to a potential split of the gnucash product in a real libgnucash and "libgnucash-consumers" we may want to create a libgnucash product now as well managing all the lower level components (backends, engine, ...)
05:33:19 <gjanssens> And GnuCash and Bindings as products for the libgnucash-consumers.
05:33:37 <gjanssens> This split may be too early though.
05:36:26 *** harshitaneja has quit IRC
05:37:38 <gjanssens> Gnome bugzilla has a summary report - https://bugzilla.gnome.org/page.cgi?id=weekly-bug-summary.html
05:37:49 <gjanssens> This is missing in gnucash bugzilla. Was this a gnome customization ?
05:40:05 <gjanssens> I am a heavy user of the browse page. On gnomebz this had plenty of statistics on a product. There are all gone. Is this because I'm not yet known as a developer or was this a gnome customization ?
05:41:35 *** harshitaneja has joined #gnucash
05:44:24 *** fekepp has quit IRC
05:44:58 <gjanssens> Each bug report now has a block for effort estimates and accounting. Do we want to keep this ? And can it be (globally) disabled via configuration ?
05:45:41 *** fabior has joined #gnucash
05:53:51 <gjanssens> Looking at attachments and attachment statuses again. Without a status flag it is effectively more difficult to track a patch' status.
05:54:11 <gjanssens> I just took the first example: https://bugzilla.gnucash.org/bugzilla/show_bug.cgi?id=570011
05:54:41 <gjanssens> I had to read through the whole bug to understand improvemements were requested and not yet provided.
05:56:29 <gjanssens> So I'm in two minds about this. I do understand it would require bugzilla customization however without it bugzilla gets yet a bit more cumbersome to manage patches.
05:57:37 <gjanssens> We could also change our patch policy and only accept PR's over github (who would have thought when we started with git several years ago I'd one day consider proposing that...)
05:59:21 <gjanssens> The subtle pinch there is that it would mean we start to depend solely on a proprietary service to accept code contributions from a non-commiter
05:59:43 <gjanssens> Which is not ideal for a project promoting free software :(
06:08:50 *** jotrago has joined #gnucash
06:47:50 *** oozer has joined #gnucash
07:02:45 *** Jimraehl1 has joined #gnucash
07:03:22 *** Jimraehl1 has left #gnucash
07:06:06 *** fabior has quit IRC
07:15:19 *** jotrago has quit IRC
07:16:58 *** jotrago has joined #gnucash
07:20:06 *** jotrago has quit IRC
07:25:58 *** fekepp has joined #gnucash
07:34:01 *** boldstripe has joined #gnucash
07:49:20 <warlord> gjanssens: thanks. I'll try to copy-and-paste your feedback into email for posterity.
08:28:15 <warlord> gjanssens: responded by email.
08:29:02 <gjanssens> warlord: thanks
08:29:54 <warlord> And... time tracking is turned off
08:29:57 <warlord> (hopefully)
08:31:54 <gjanssens> Yep, it's gone
08:34:48 *** chris_ has joined #gnucash
08:35:27 *** jotrago has joined #gnucash
08:35:31 *** chris1 has joined #gnucash
08:37:33 <chris1> (Just wish to dump my understanding of unit testing) - I'll be designing test-invoice.scm and friends to formally 'freeze' the implementation of invoices as they currently stand... i.e. no increased functionality, no hunting for bugs.
08:38:24 <chris1> i.e. most invoice.scm & friends options and features will be stabilised and confirm unchanged.
08:38:41 <chris1> because eventually I'll want to merge invoice.scm and friends and expect all tests to pass
08:39:12 <chris1> otherwise a bit busy with real-life study and will do this in spare minutes
08:49:10 <warlord> gjanssens: Great. So really it's just the attachment status and potential restructuring.
08:51:19 <gjanssens> chris1: that's the concept
08:51:44 <gjanssens> However in practise I suppose you will need to adjust the unit tests depending on your restructuring
08:52:21 <gjanssens> I don't expect the outputted html to be bit by bit exactly the same for the unified report or the old separate reports
08:53:09 <gjanssens> I do expect the new unified report to be flexible enough to generate html output that's visually very close to what the old reports did, but it may differ in details
08:53:38 <gjanssens> The unit tests should mostly guard all configurable aspects continue to work.
08:54:16 <gjanssens> I realize this is all a bit hand-wavy but I don't know how to explain it more clearly or precisely
08:54:42 <chris1> Lol got the overall idea...
08:56:07 *** harshitaneja has quit IRC
09:02:07 *** harshitaneja has joined #gnucash
09:05:04 *** kael has joined #gnucash
09:26:08 *** harshitaneja_ has joined #gnucash
09:27:43 *** harshitaneja has quit IRC
09:28:02 <chris1> :( I'm adding invoice figures from gnucash-user into my test and the figures don't match :( :(
09:28:30 *** harshitaneja_ is now known as harshitaneja
09:29:48 <chris1> so, gjanssens unfortunately will wish to recruit your help again
09:29:50 <chris1> https://imgur.com/a/KlHP0TR
09:34:26 <gjanssens> chris1: what's wrong with the screenshot ?
09:35:30 <chris1> today's reports that the total = $370, its 13% tax should be $48.10 rather than the reported $48.11, but the scheme amounts show $48.09
09:35:57 <chris1> today's bug-of-the-day in -user
09:38:13 <gjanssens> Right. The user report was probably on 2.6, while your test runs on 3.x
09:38:31 <gjanssens> It looks like 3.x is truncating rather than rounding.
09:39:00 <gjanssens> Which is yet another bug. They proliferate quickly these days...
09:43:05 *** oozer has quit IRC
09:43:13 <chris1> so, I'm not sure what to do... perhaps I'll leave this rounding issue untested for now and focus on testing the reporting parts only
09:45:02 <gjanssens> Well, it's weirder than that.
09:45:26 <chris1> it's on my branch scheme-invoice-with-rounding-issue and I'll leave it alone for your perusal
09:45:30 <gjanssens> I'm trying to reproduce and I do indeed get consistently 48.11 as tax amount
09:46:39 <gjanssens> Or more precisely if I create an invoice in gnucash 3.1+ I consistently get that amount. I haven't tested what happens when directly created from scheme
09:46:56 <gjanssens> What happens if you create the invoice via the gnucash gui ?
09:47:12 <chris1> ditto 48.11
09:48:44 <gjanssens> Ok, so the scheme path is still different from the c path in some way. I suspect this happens because tax percentages are stored internally with 6 significant digits where guile only passes whole numbers (it automatically reduces rationals)
09:49:45 <gjanssens> Perhaps this is fixed if I correct the rounding strategy for the multiplications as I suggested in my commit message.
09:59:01 <chris1> This will be a headache. I've just tried (gnc-numeric-create 1300 100) instead of 13 for all numbers, and same result. I think I'll park this and let you decide what's best. The branch scheme-invoice-with-rounding-issue will create offending invoice in /tmp/test-inv-inv-1-add--277-5-and--92-50-plus-13--taxes.html
10:02:09 <gjanssens> Try (gnc-numeric-create 1300000 100000) (assuming gnc-numeric-create doesn't reduce)
10:05:08 <chris1> no change.
10:05:27 <chris1> i wonder if jralls has effectively neutralized gnc-numeric-create a few months ago
10:07:32 <chris1> hmm i think I'm right... whether I store 13 or gnc-numeric-create in gncEntrySetQuantity, the gncEntryGetQuantity returns a number
10:38:20 <gjanssens> chris1: no I think it's guile doing the auto reduction. Each time the gncnumeric passes through guile interpretation it will be reduced
10:38:48 <gjanssens> But clearly our code should be able to handle this
10:38:55 <gjanssens> (where it currently doesn't)
10:39:45 <gjanssens> We have been discussing this around the time jralls converted GncNumeric to c++ and our conclusion was we should never round except when storing or displaying.
10:40:14 <gjanssens> The current code base is not doing that and it will take lots of corrections to get there.
10:45:34 <chris1> ok in any case i'll choose easier numbers for test-invoices
10:46:22 <chris1> perhaps there should be a test-numeric.scm
10:49:41 <gjanssens> chris1: that would be useful indeed.
10:50:23 <gjanssens> And there should also be a test-gncentry.c and a test-<name-your-source-file>.<ext> for what it's worth :)
10:50:46 *** jotrago has quit IRC
10:50:47 <gjanssens> I'm grateful you are already picking up some of those
10:51:40 <gjanssens> Oh hang on, there is a utest-Entry.c already :)
10:51:44 <gjanssens> Time to update this one
10:52:05 <gjanssens> I can easily simulate your scheme issues in C so I can catch those errors in there already
10:54:46 <chris1> I'll leave C for you... us schemers are spoilt to never worry about malloc and friends
10:55:25 *** harshitaneja has quit IRC
10:55:27 <chris1> I'll try remember convert gtest-gnc-numeric.c to test-gnc-numeric.scm as wel
10:57:42 *** harshitaneja has joined #gnucash
11:29:48 <chris1> the gratitude is mine too... always had reservations about Quicken
11:47:05 *** ArtGravity has joined #gnucash
11:47:59 *** Mechtilde has joined #gnucash
11:51:12 *** calvinct has joined #gnucash
11:53:10 *** marusich has quit IRC
11:55:03 *** GabrieleV has quit IRC
12:01:12 *** GabrieleV has joined #gnucash
12:12:13 *** jotrago has joined #gnucash
12:23:29 *** fabior has joined #gnucash
12:47:32 *** kael has quit IRC
12:49:07 *** kael has joined #gnucash
12:51:55 *** calvinct has quit IRC
12:56:11 *** gour_ has joined #gnucash
12:58:30 *** gour has quit IRC
12:58:57 *** bertbob has quit IRC
13:01:13 *** bertbob has joined #gnucash
13:09:14 *** fekepp has quit IRC
13:16:05 *** fabior has quit IRC
13:27:38 *** bertbob has quit IRC
13:35:29 *** fekepp has joined #gnucash
13:39:43 *** bertbob has joined #gnucash
13:40:15 *** calvinct has joined #gnucash
13:42:36 *** bertbob has quit IRC
13:44:26 *** bertbob has joined #gnucash
14:13:14 *** calvinct has joined #gnucash
14:14:57 *** oozer has joined #gnucash
14:17:46 *** calvinct has quit IRC
14:18:40 *** fell_afk is now known as fell
14:18:51 *** gncbot sets mode: +o fell
14:50:37 *** ncv has quit IRC
14:52:42 *** fekepp1 has joined #gnucash
14:53:02 *** fekepp has quit IRC
14:53:03 *** fekepp1 is now known as fekepp
14:57:13 *** brianjaod has joined #gnucash
14:57:18 *** brianjaod has left #gnucash
15:18:03 *** kael has quit IRC
15:20:16 <warlord> jralls: BTW, I definitely will need to blow away our bugs DB at least one more time -- for the final migration. So I don't see the harm in blowing it away a few additional times between now and then.
15:33:57 *** jotrago has quit IRC
15:34:00 *** jotrago has joined #gnucash
16:00:45 *** fell_laptop has joined #gnucash
16:14:31 *** Mechtilde has quit IRC
16:16:08 *** kael has joined #gnucash
16:18:14 *** gjanssens has quit IRC
16:30:53 *** gour_ has quit IRC
16:31:48 *** kael has quit IRC
16:37:28 *** calvinct has joined #gnucash
16:46:40 *** calvinct has quit IRC
17:06:30 *** calvinct has joined #gnucash
17:14:45 *** calvinct has quit IRC
17:18:35 *** frakturfreak has quit IRC
18:31:53 *** fekepp has quit IRC
18:38:06 *** pilotauto has joined #gnucash
19:02:42 *** boldstripe has quit IRC
19:16:38 *** gringotts has joined #gnucash
19:20:03 <gringotts> Good day gnucash people!
19:21:16 <gringotts> I'm looking for a little guidance on importing to GnuCash. I'm stuck on a seeming requirement for withdrawl or deposit column ("Please select a deposit or withdrawl column.")
19:21:41 <gringotts> Checking the source, yup it wants one or both.
19:22:14 <gringotts> My bank doesn't supply that with its CSV downloads, so what do you suggest I do?
19:24:49 <gringotts> Here's what I do get, left to right: Details (DEBIT|CREDIT), Date (mm/dd/yyyy), Description (arb text), Amount (float), Type (DEBIT CARD|ATM|FEE TRANS|MISC CREDIT|CHECK_PAID|+ a few more), Balance (float), Notation (check or slip nr.)
19:25:55 <gringotts> Should I write a little script to transform this CSV and produce Withdrawl & Deposit columns, based on the Details and Amount columns?
19:31:27 *** fell_laptop has quit IRC
19:32:55 *** chris1 has quit IRC
19:41:03 *** gringotts has quit IRC
20:04:40 *** boldstripe has joined #gnucash
20:18:42 *** jonas_ has quit IRC
20:25:13 *** jonas_ has joined #gnucash
20:25:38 *** gringotts has joined #gnucash
22:50:12 *** gringotts has quit IRC
22:57:17 *** ArtGravity has quit IRC
23:06:46 *** Cuare has joined #gnucash
23:28:13 *** chris1 has joined #gnucash