2018-04-28 GnuCash IRC logs
00:01:42 *** pilotauto has quit IRC
00:02:54 *** pilotauto has joined #gnucash
01:23:54 *** fell has quit IRC
01:24:57 *** fell has joined #gnucash
01:50:58 *** gjanssens has joined #gnucash
01:50:58 *** ChanServ sets mode: +o gjanssens
01:55:44 *** Guest56 has quit IRC
02:01:59 *** warlord has quit IRC
02:03:19 *** Mechtilde has joined #gnucash
02:05:32 <gjanssens> .
02:21:10 *** gour has joined #gnucash
02:24:53 *** gour has quit IRC
02:25:11 *** gour has joined #gnucash
02:26:46 <chris> I think UI in QIF import in maint is broken
02:27:40 <chris> current maint: http://i.imgur.com/hdX2kvl.png
02:32:49 *** jotrago1 has joined #gnucash
02:38:40 <chris> gjanssens - there's a continuation to string-sanitization with a small dilemma - I believe *all* user-selectable strings (eg txn-description, report-title, acct-names) must be sanitized - this means a whole lot of gnc:html-string-sanitize in all reports.
02:38:45 <chris> but there's another way
02:43:44 <chris> the second option is to enforce a blanket rule in html-style-info.scm that *all* strings must be sanitized. This includes the (gnc:render-options-changed) function that I made which must be redone, otherwise it'll be rendered as text: https://imgur.com/a/JPBziyy
02:44:24 <chris> I guess the burden of making such a decision will fall to me...
02:52:50 *** CDB-Away has joined #gnucash
02:55:07 *** CDB-Away has quit IRC
02:55:24 *** CDB-Away has joined #gnucash
03:15:05 *** chris has quit IRC
03:15:16 *** chris has joined #gnucash
03:52:50 *** pilotauto has quit IRC
04:15:28 <gjanssens> chris: I think the blanket rule is a good idea. I note the string renderer is called "gnc:default-html-string-renderer"
04:15:38 <gjanssens> That suggests you could override it in some way
04:15:50 <gjanssens> Perhaps that's what you want to do in this case ?
04:16:18 <gjanssens> I haven't looked at the details though
04:17:42 <gjanssens> Or you could have two string adding functions: one that sanitizes and one that doesn't for strings you know have been sanitized in another way.
04:18:55 <gjanssens> And one last random thought: perhaps gnc:render-options-changed needs to become a wrapper around a core function that sits next to the gnc:default-html-xyz functions
04:19:47 <gjanssens> That would bring all sanitizing needs together in one file.
04:19:59 <gjanssens> As said I haven't really dug into how all this ties together...
04:20:18 <gjanssens> So perhaps these conceptual ideas just don't make any sense
04:21:40 *** harshitaneja has joined #gnucash
04:25:42 *** fabior has joined #gnucash
05:12:03 <chris> gjanssens - +1 for blanket rule. the next dilemma is either to allow 2 string functions (sanitize, or allow-raw) (btw a signal can be used eg (if (eqv? (string-ref str 0) #\bs) str (gnc:html-string-sanitize str) = Ewwwwww), or to modify existing functions to use html-document objects
05:12:28 <chris> I'll think about it
05:14:37 <gjanssens> Ok
05:20:00 <chris> I think correctness means reusing existing html-document functions but I'd be wary they may not expose enough html capabilities. Only 1 way to find out.
05:40:30 *** fabior has quit IRC
05:54:52 *** Mechtilde has quit IRC
06:17:32 *** gncbot sets mode: +o fell
07:13:31 *** Aussie_matt has joined #gnucash
07:40:41 *** Jimraehl1 has joined #gnucash
07:41:25 *** Jimraehl1 has left #gnucash
08:41:45 *** User_ has joined #gnucash
08:44:48 *** User_ has quit IRC
08:45:19 *** boldstripe has joined #gnucash
08:53:54 *** fabior has joined #gnucash
09:01:22 *** kael has joined #gnucash
09:07:48 *** kael has quit IRC
09:40:26 *** ncv has joined #gnucash
09:41:08 *** ncv has quit IRC
09:42:08 *** ncv has joined #gnucash
10:05:15 <gjanssens> jralls: while looking at ways to get ofx working I noticed there's already a 0.9.12 release. I chose to stick with 0.9.10 for the 3.10 release to avoid getting a new set of issues.
10:05:26 <gjanssens> Eh, 3.1
10:05:35 *** Aussie_matt has quit IRC
10:06:13 <gjanssens> After release I will look into upgrading to 0.9.12 and creating a patch for that version (our 0.9.10 patch wan't apply cleanly)
10:21:24 *** Guest56 has joined #gnucash
10:50:31 *** gour_ has joined #gnucash
10:50:34 *** Guest56 has quit IRC
10:52:19 *** chris_ has joined #gnucash
10:52:30 *** chris_ is now known as chris-L
10:52:41 *** gour has quit IRC
10:56:18 *** oozer has joined #gnucash
11:05:25 *** boldstripe has quit IRC
11:14:47 *** O01eg has quit IRC
11:28:03 *** Mechtilde has joined #gnucash
11:59:14 *** fekepp has quit IRC
12:09:56 *** fekepp has joined #gnucash
12:38:12 <gjanssens> jralls: I'll be afk this evening again.
12:38:38 <gjanssens> I went over the current bug list and I think we're almost ready for a release.
12:39:29 <gjanssens> The chinese input issues are still troublesome https://bugzilla.gnome.org/show_bug.cgi?id=795253 but can be mentioned as a known issue IMO
12:40:34 <gjanssens> Same for https://bugzilla.gnome.org/show_bug.cgi?id=795272 (qif import potential crash if import file has invalid tags) and importing of huge csv files (https://bugzilla.gnome.org/show_bug.cgi?id=795383)
12:41:04 <gjanssens> Importing is not critical path and both can be worked around to continue.
12:42:00 <gjanssens> I also went over the bugs in NEEDINFO status. Most crashers there seem to be issues we believe are fixed but are waiting for user confirmation.
12:42:25 <gjanssens> Question is how long should we wait for a confirmation ?
12:43:16 <gjanssens> I'll leave it up to you and what you still plan to do today whether or not it would be suitable to make a release this weekend.
12:54:18 *** gjanssens is now known as gjanssens_afk
13:15:52 *** fabior has quit IRC
13:35:10 *** fekepp1 has joined #gnucash
13:35:42 *** fekepp has quit IRC
13:35:43 *** fekepp1 is now known as fekepp
13:37:44 <jralls> gjanssens_afk: Re: LibOFX, hold off on 0.9.12, see https://bugzilla.gnome.org/show_bug.cgi?id=795347#c2.
13:49:28 *** User_ has joined #gnucash
14:17:41 *** Mechtilde has quit IRC
14:40:42 *** frakturfreak has joined #gnucash
16:21:40 *** gour_ has quit IRC
16:24:13 *** ncv has quit IRC
16:24:20 *** ncv has joined #gnucash
16:34:47 *** User_ has quit IRC
18:31:18 *** kael has joined #gnucash
18:41:05 <gjanssens_afk> jralls: yes, I had seen that comment. My intention is to clean up the ofx patch to send it upstream somewhere next week.
18:41:20 <gjanssens_afk> Then we can indeed go for 0.9.13 at once.
18:41:40 <jralls> OK. You're not logged in to the Windows VM, are you?
18:42:01 <jralls> I'm stalled out at the "Connected to graphic server" black screen.
18:42:17 *** oozer has quit IRC
18:45:59 <gjanssens_afk> No, I'm not. I had to reboot it this morning once as well
18:46:17 <gjanssens_afk> warlord's connection is a bit underpowered currently.
18:46:32 <jralls> Yeah, prolly for most of the rest of the year.
18:46:41 <gjanssens_afk> Good luck with the release! I'm off to bed...
18:46:45 <gjanssens_afk> Night!
18:48:31 *** gjanssens_afk has quit IRC
19:09:41 *** oozer has joined #gnucash
19:41:46 *** kael has quit IRC
19:43:00 *** warlord has joined #gnucash
19:51:51 *** kael has joined #gnucash
19:54:13 *** kael has quit IRC
20:12:39 <jralls> warlord: Please delete gnucash-3.1.setup.exe from builds/win32/releases. The blinking OFX bug is still not fixed.
20:52:45 *** frakturfreak has quit IRC
21:39:26 *** Robert847 has joined #gnucash
21:39:32 *** Robert847 has left #gnucash
21:57:02 *** boldstripe has joined #gnucash
22:00:27 *** boldstripe has quit IRC
22:07:18 *** Aussie_matt has joined #gnucash
22:31:56 *** oozer has quit IRC
22:45:36 *** ncv has quit IRC