2018-01-20 GnuCash IRC logs
16:35:32 *** gncbot has joined #gnucash
16:35:37 *** warlord sets mode: +o gncbot
16:35:49 <warlord> And I think the move is done.
16:40:05 *** warlord has quit IRC
16:44:51 *** marusich has quit IRC
16:47:34 *** kus has joined #gnucash
17:06:49 *** kus has quit IRC
17:09:01 *** bob_ has quit IRC
17:31:53 *** warlord has joined #gnucash
18:06:51 *** oozer has quit IRC
18:07:06 *** oozer has joined #gnucash
18:07:30 *** oozer_ has joined #gnucash
18:20:27 <chris> thx for merge jralls - one last commit bb30064723 for PR259 and it's done
18:20:27 <gncbot> chris: Sent 1 day, 9 hours, and 16 minutes ago: <fell> It might help first time users, if the 2 tables of your TR would have titles.
18:23:29 *** steff972 has joined #gnucash
18:44:09 *** steff972 has quit IRC
18:53:26 <chris> jralls oops there's a few pricedb conversions missing which is breaking reports. I think lmat was working on it. we'll have to fix this urgently.
18:55:15 <jralls> chris: What are the pricedb functions?
18:55:38 <chris> gnc_pricedb_convert_balance_nearest_price still expects ts
19:00:14 <chris> I've pushed into time64-ftw but please triple check my C
19:08:17 <jralls> That's kind of a lazy fix, and you didn't fix the tests.
19:10:22 <chris> ok
19:13:24 <jralls> I see why you took the lazy way, because it cascades. But even letting that slide the tests will fail to compile.
19:17:13 <jralls> Heh, following the cascade I see that lmat made a gnc_pricedbu_lookup_nearest_in_time64, but it just echoes the call to lookup_nearest_in_time, which takes a Timespec*... he forgot to create one from the time64. That should have thrown a compiler error.
19:18:50 <jralls> Oh, no, I'm wrong. Looking in the wrong place.
19:33:13 <jralls> chris: So your C gets a "C". ;-) It turned out not to be hard to handle the cascade, only a couple of statics needed to be converted; they called functions that lmat had already made t64 alternatives for.
19:34:06 <jralls> Otherwise your changes were correct and you got everything except the tests.
19:44:41 <jralls> The commit message was a bit too general, too. It wasn't all of gnc_pricedb, after all, just the one function. But if you want to practice your C, by all means do the rest of the file! ;-)
19:48:33 <chris> this is trial by fire
19:48:48 <jralls> Very friendly fire! ;-)
19:49:02 <jralls> Nerf guns, even.
19:49:29 <chris> ;_
19:49:33 <chris> ;)
19:50:25 <jralls> Had you run ninja check before pushing it would have reminded you about the tests.
19:57:24 *** kus has joined #gnucash
21:37:17 *** oozer has quit IRC
21:43:28 *** frakturfreak has quit IRC
22:34:03 *** kus has quit IRC