2018-01-19 GnuCash IRC logs
00:20:11 *** Robert has left #gnucash
01:18:39 *** Mechtilde has joined #gnucash
01:33:20 *** harshitaneja has joined #gnucash
01:37:36 *** marusich has joined #gnucash
01:37:58 *** fell has quit IRC
01:39:11 *** fell has joined #gnucash
02:13:30 *** Mechtilde has quit IRC
02:14:09 *** marusich has quit IRC
02:14:27 *** marusich has joined #gnucash
02:20:55 *** chris_1 has joined #gnucash
02:30:35 *** chris_ has quit IRC
03:01:11 <chris_1> :( I was hacking TR to allow hyperlink from subtotal grid to the relevant section in main table, but the webkit renderer doesn't allow intra-document jumps
03:01:28 <chris_1> export to firefox shows the html logic is sound
03:05:28 <chris_1> here is "what-TR-could-be" https://pste.eu/p/hQyP.html
03:08:56 <chris_1> I'll have to scratch this idea
03:31:11 *** chris_1 has quit IRC
03:41:33 *** Mechtilde has joined #gnucash
03:54:05 *** marusich has quit IRC
03:54:23 *** marusich has joined #gnucash
04:02:08 *** marusich has quit IRC
04:02:26 *** marusich has joined #gnucash
04:04:09 *** fekepp has joined #gnucash
04:13:16 *** fekepp has quit IRC
04:24:44 *** flips has quit IRC
04:24:49 *** flips has joined #gnucash
04:43:34 *** fabior has joined #gnucash
05:03:14 *** fabior has quit IRC
05:20:09 *** marusich has quit IRC
05:20:28 *** marusich has joined #gnucash
05:25:04 *** fabior has joined #gnucash
05:25:46 *** marusich has quit IRC
05:39:52 *** fabior has quit IRC
05:56:02 *** fabior has joined #gnucash
06:16:31 *** jotrago has joined #gnucash
06:20:14 *** chris has joined #gnucash
06:50:20 *** chris has quit IRC
06:56:52 *** fabior has quit IRC
07:36:10 *** bob_ has joined #gnucash
07:53:49 *** harshitaneja has quit IRC
08:00:26 *** harshitaneja has joined #gnucash
08:08:02 *** bob_ has quit IRC
08:19:48 *** User has joined #gnucash
08:24:27 *** harshitaneja has quit IRC
08:27:27 *** gjanssens has joined #gnucash
08:27:27 *** ChanServ sets mode: +o gjanssens
08:32:25 *** User has quit IRC
08:40:29 *** gncbot sets mode: +o fell
08:43:10 *** oozer has joined #gnucash
08:58:47 *** storyjesse has joined #gnucash
09:00:22 *** harshitaneja has joined #gnucash
09:03:55 <fell> @tell chris It might help first time users, if the 2 tables of your TR would have titles.
09:03:55 <gncbot> fell: The operation succeeded.
09:14:53 *** fabior has joined #gnucash
09:20:34 *** fabior has quit IRC
09:36:59 *** storyjesse has quit IRC
09:59:04 *** jotrago has quit IRC
10:01:00 *** oozer has quit IRC
10:15:39 *** gnomey has quit IRC
10:16:57 *** Mechtilde has quit IRC
10:17:26 *** gnomey has joined #gnucash
10:19:12 *** kael has joined #gnucash
10:22:57 *** harshitaneja has quit IRC
10:44:27 *** ArtGravity has joined #gnucash
10:48:19 *** shoonya has joined #gnucash
11:40:45 *** shoonya has quit IRC
11:43:56 *** jralls_afk has quit IRC
11:46:59 *** jralls_afk has joined #gnucash
11:54:39 *** fabior has joined #gnucash
11:59:23 *** shoonya has joined #gnucash
12:00:31 *** kael has quit IRC
12:01:29 *** jralls_afk is now known as jralls
12:02:11 *** ChanServ sets mode: +o jralls
12:33:34 *** kael has joined #gnucash
13:03:18 *** shoonya has quit IRC
13:05:29 *** O01eg has quit IRC
13:18:01 *** O01eg has joined #gnucash
13:20:05 *** Mechtilde has joined #gnucash
13:27:15 *** oozer has joined #gnucash
13:32:08 *** fabior has quit IRC
13:48:23 *** Mechtilde has quit IRC
13:52:31 *** Mechtilde has joined #gnucash
14:02:38 *** kael has quit IRC
14:23:25 *** frakturfreak has joined #gnucash
14:39:53 *** Mechtilde has quit IRC
14:40:22 *** kael has joined #gnucash
14:44:32 <gjanssens> jralls: there are a few small leftovers from the bye,bye autotools merge
14:44:41 <gjanssens> I'm in the process of cleaning those up
14:45:00 <gjanssens> What do you want us to do with the test-templates subdir ?
14:45:36 <gjanssens> Looks to me this is now obsolete as well. We don't want more glib based tests added in 2.7 and beyond or do we ?
14:45:43 <jralls> gjanssens: OK. I think I found one of them yestarday while I was working on the python bindings for time64-ftw, in basic-typemaps.i.
14:46:35 <jralls> gjanssens: I agree, it's obsolete. We want to use googletest for new tests. Do you think it's worthwhile to modify it for that?
14:48:04 <gjanssens> Hmm, perhaps that could help others with less experience in unit-test writing indeed
14:48:31 <gjanssens> Although I found it fairly easy to start with myself
14:48:55 <gjanssens> Except perhaps adding new tests in the CMakeLists.txt files
14:49:09 <gjanssens> I still find that fairly cumbersome and verbose
14:50:24 *** Mechtilde has joined #gnucash
14:53:56 <jralls> test-templates doesn't really help much with test writing; it creates a test file with a commented-out test function for each of the functions in a module along with indications of whether used inside or outside of the file. The idea is to help you prioritize which functions to write tests for. If you're doing a new file and something resembling TDD then it's not terribly helpful.
15:13:41 *** Mechtilde has quit IRC
15:15:27 *** User has joined #gnucash
15:17:38 *** kael has quit IRC
15:24:22 *** User has quit IRC
15:25:43 *** gjanssens is now known as gjanssens_afk
15:27:37 *** fabior has joined #gnucash
15:30:42 *** kael has joined #gnucash
15:32:53 *** Mechtilde has joined #gnucash
15:34:19 *** meb has quit IRC
15:34:30 *** hoijui has joined #gnucash
15:36:21 *** meb has joined #gnucash
15:48:54 *** kael has quit IRC
15:57:44 *** kael has joined #gnucash
16:04:17 *** meb has quit IRC
16:12:27 *** hoijui has quit IRC
16:20:52 *** Mechtilde has quit IRC
16:23:55 *** kael has quit IRC
16:52:29 *** MrKeuner has quit IRC
17:15:45 *** gjanssens_afk is now known as gjanssens
17:18:52 <gjanssens> jralls: I haven't really done TDD yet, but I follow your reasoning.
17:19:07 <jralls> ;-)
17:19:32 <gjanssens> The creation of the test file was done with "make-testfile"
17:19:35 <jralls> I haven't really done it either. If I'm paying attention I'll write a function and then write a test.
17:19:52 <jralls> Uh, which test file?
17:20:14 <gjanssens> "it creates a test file with a commented-out test function for each of the functions in a module along with indications of whether used inside or outside of the file"
17:20:32 <gjanssens> But that's highly glib based testing oriented
17:20:59 <gjanssens> And IIUC intended to help catch up for missing tests in our current code
17:21:32 <gjanssens> We expect new C++ code to come with tests as a rule (more or less)
17:21:47 <jralls> Yes, but it wouldn't be hard to take out the glib-test based bits and substitute googletest-base bits.
17:22:27 <gjanssens> Ok. So the question remains how much value would that have ?
17:22:53 <gjanssens> In the case of my csv importer classes it would probably save me some typing
17:23:58 <gjanssens> However it only helps the first time.
17:24:01 <jralls> Agreed. But we still need tests for the older code. I find it very comforting to have good tests on the major functions in a module before I rewrite it into C++. It helps to delude myself into believing that I haven't screwed anything up too badly.
17:24:34 <gjanssens> So that's an argument towards keeping glib test templates
17:24:53 <jralls> Why? googletest can test C functions.
17:25:08 <jralls> And googletest tests are a *lot* faster to write.
17:25:13 <gjanssens> Ah, I didn't realise that.
17:25:37 <gjanssens> What's also missing then are the bits and pieces to generate/add to a CMakeLists.txt file instead of Makefile.am
17:25:58 <gjanssens> It's still Makefile oriented
17:27:10 <jralls> Yes, though the add-test macro in cmake-modules helps quite a lot, and not having libraries splattered all over the builddir helps even more.
17:28:07 <gjanssens> Probably. I haven't looked too deeply into this.
17:28:39 <gjanssens> My bottom line is, let's keep the test-templates and rewrite them for googletest/cmake
17:28:53 <jralls> I agree.
17:28:54 <gjanssens> But more on that will have to wait for later.
17:29:00 <gjanssens> Time to go to bed
17:29:08 <gjanssens> Bye all!
17:29:15 <jralls> The whole thing can wait for later. Good night!
17:30:09 *** gjanssens has quit IRC
17:37:27 *** Mechtilde has joined #gnucash
17:46:39 *** fabior has quit IRC
17:55:57 *** Mechtilde has quit IRC
17:57:25 *** Mechtilde has joined #gnucash
18:39:45 *** Mechtilde has quit IRC
19:04:38 *** frakturfreak has quit IRC
20:15:57 *** kus has joined #gnucash