2017-12-28 GnuCash IRC logs

01:08:19 *** Mechtilde has joined #gnucash
01:31:14 *** fell has quit IRC
01:32:24 *** fell has joined #gnucash
01:47:04 *** Mechtilde has quit IRC
03:19:28 *** gjanssens has joined #gnucash
03:19:28 *** ChanServ sets mode: +o gjanssens
03:25:30 *** storyjesse has joined #gnucash
04:47:31 *** fabior has joined #gnucash
04:48:42 <gjanssens> .
05:24:43 *** xmaka has quit IRC
05:26:01 *** xmaka has joined #gnucash
05:29:11 *** xmaka has quit IRC
05:42:15 *** Mechtilde has joined #gnucash
05:50:03 *** chris has quit IRC
06:00:23 *** xmaka has joined #gnucash
06:31:43 *** User has joined #gnucash
07:05:02 *** noah has joined #gnucash
07:19:41 *** noah has quit IRC
07:20:28 *** Jimraehl1 has joined #gnucash
07:20:29 *** noah has joined #gnucash
07:20:46 *** Jimraehl1 has quit IRC
07:23:56 *** noah has quit IRC
07:24:36 *** noah has joined #gnucash
07:31:51 *** noah has quit IRC
07:34:29 *** noah has joined #gnucash
07:37:40 *** fabior has quit IRC
07:42:20 *** fekepp has joined #gnucash
07:52:03 *** fabior has joined #gnucash
08:02:48 *** noah has quit IRC
08:11:10 *** noah has joined #gnucash
08:13:56 *** noah has quit IRC
08:14:35 *** noah has joined #gnucash
08:19:26 *** noah has quit IRC
08:24:29 *** fabior has quit IRC
08:24:46 *** noah has joined #gnucash
08:36:58 *** noah has joined #gnucash
08:37:55 *** noah has quit IRC
08:38:36 *** noah has joined #gnucash
08:45:05 *** xmaka has quit IRC
08:45:48 *** xmaka has joined #gnucash
08:58:09 *** noah has quit IRC
08:59:02 *** noah has joined #gnucash
09:03:13 *** noah has quit IRC
09:05:54 *** noah has joined #gnucash
09:12:05 *** xmaka has quit IRC
09:12:20 *** xmaka has joined #gnucash
09:33:46 *** noah has quit IRC
09:34:20 *** noah has joined #gnucash
09:37:55 *** noah has quit IRC
09:38:41 *** noah has joined #gnucash
09:41:14 *** Mechtilde has quit IRC
09:43:22 *** noah has quit IRC
09:44:51 *** noah has joined #gnucash
09:47:54 *** noah has quit IRC
09:48:35 *** noah has joined #gnucash
09:54:45 *** fekepp has quit IRC
10:08:33 *** noah has quit IRC
10:09:27 *** noah has joined #gnucash
10:12:55 *** noah has quit IRC
10:13:52 *** noah has joined #gnucash
10:34:45 *** Mechtilde has joined #gnucash
10:37:32 *** hoijui has joined #gnucash
10:43:26 *** Mechtilde has quit IRC
10:49:02 *** ArtGravity has joined #gnucash
10:53:01 *** fabior has joined #gnucash
10:56:33 *** noah has quit IRC
12:06:34 <jralls> gjanssens: We need to discuss 2.7.3 release and freezes. If we merge PRs 142 and 244 along with the patch on bug 791993 (which I haven't yet looked at) I think we'll be feature-complete for 2.8 and can continue working on other ongoing stuff including refining the style in PR 142.
12:08:04 <jralls> gjanssens: I don't expect that we'll have any new strings in that so we can point the Translation Project at the 2.7.3 tarball and make an announcement on gnucash-devel to the other translators that they can go to work on it.
12:11:42 <jralls> gjanssens: I've got to go run errands for 2-3 hours, I'll read any comments when I return.
12:11:49 *** jralls is now known as jralls_afk
12:22:59 *** User has quit IRC
12:33:08 <gjanssens> jralls_afk: I'll check out PR#244 tomorrow. It should be quite mature by now
12:34:20 <gjanssens> jralls_afk: I think it would be useful to merge PR#142 as is because either it blocks my fixes on the csv importer or I will break the PR whichever happens first
12:34:37 <gjanssens> jralls_afk: I'll try to redo a functional check of that PR tomorrow as well.
12:36:33 <gjanssens> jralls_afk: I have not yet looked at the patch on bug 791993 either. If you have time, I'll let that for you.
12:36:50 <gjanssens> jralls_afk: And yes, I think we're ready for feature/string freeze then.
12:37:35 <gjanssens> jralls_afk: I'll be afk the remainder of the evening, but can read still read comments in an hour or 4.
12:38:03 *** storyjesse has quit IRC
12:41:25 *** gjanssens is now known as gjanssens_afk
13:26:47 *** fekepp has joined #gnucash
14:15:52 *** Mechtilde has joined #gnucash
14:46:26 *** frakturfreak has joined #gnucash
14:47:07 *** ah has joined #gnucash
14:56:49 *** CDB-Man has quit IRC
14:57:43 *** ah has quit IRC
14:57:45 *** ah has joined #gnucash
14:58:05 *** fabior has quit IRC
14:58:10 *** CDB-Man has joined #gnucash
14:58:34 *** ah has quit IRC
14:59:54 *** User has joined #gnucash
15:00:25 *** gnomey has quit IRC
15:02:02 *** gnomey has joined #gnucash
15:03:40 *** fekepp has quit IRC
15:03:42 *** fekepp has joined #gnucash
15:04:58 *** ArtGravity has quit IRC
15:05:12 *** ArtGravity has joined #gnucash
15:06:33 *** jralls_afk is now known as jralls
15:06:41 <jralls> .
15:10:53 *** fekepp1 has joined #gnucash
15:11:24 *** fekepp has quit IRC
15:11:25 *** fekepp1 is now known as fekepp
15:14:25 *** fekepp has quit IRC
15:16:43 *** fekepp has joined #gnucash
15:22:22 *** fekepp1 has joined #gnucash
15:23:00 *** fekepp has quit IRC
15:23:01 *** fekepp1 is now known as fekepp
15:26:10 *** fekepp has quit IRC
15:28:01 *** fekepp has joined #gnucash
15:29:06 <lmat> @tell chris Regarding gncBillTermComputeDueDate if I'm understanding you correctly, the only uses would be by end users. Yeah, I'll just convert them, and our end users can ask for help if they need it.
15:29:06 <gncbot> lmat: The operation succeeded.
15:30:42 <lmat> jralls: I'll take a look at 9d7ec35 now.
15:32:01 *** ah has joined #gnucash
15:33:29 *** ah has quit IRC
15:44:45 <lmat> jralls: Yes, that looks like a mistake. There is another mistake of the same ilk in that same commit: around line 5135 of Account.cpp ("if (qof_instance_has_path_slot (QOF_INSTANCE (imap->acc), path))" where path is a std::vector<std::string>)
15:45:10 <lmat> et alii. I must have gotten mixed up during a rebase or something.
15:59:10 <jralls> lmat: Umm, what's the error there? path in that line is a std::vector<std::string> and that's what qof_instance_has_path_slot expects.
16:06:50 <lmat> jralls: Ah, my mistake again. That situation is fine. I was missing the _path_ distinction.
16:13:17 <jralls> lmat: Remember my comment on https://github.com/Gnucash/gnucash/pull/234 about usin glib test features newer than 2.16? Well, it turned out that you did: https://bugzilla.gnome.org/show_bug.cgi?id=792008
16:17:19 <lmat> hah! I had no idea.
16:17:42 <lmat> I can rewrite g_assert_true out of that test.
16:22:37 <jralls> Yeah, a plain g_assert will work as well.
16:24:24 *** Mechtilde has quit IRC
16:27:25 <jralls> There's also some uses in test-import-pending-matches.c.
16:37:36 <lmat> jralls: I'll knock them out.
16:37:52 <jralls> Thanks.
16:39:00 <jralls> Meanwhile I've started on time64-ftw. I see the problem, there's a lot of interlocking changes to make. I agree that it will take a while.
17:16:22 *** Jacques has joined #gnucash
17:20:11 <lmat> jralls: I think the XML data format doesn't need to change at all. I'm working on it. We can simply ignore the nanoseconds.
17:21:45 <jralls> lmat: Huh? Where did you find us storing nanoseconds in XML?
17:23:02 <jralls> I was wondering if you had any ideas for KVP to tell the difference between a time64 and any other random int, particularly in the case of a time64 coming from Scheme.
17:26:39 *** Mechtilde has joined #gnucash
17:29:50 <lmat> jralls: Well, we parse them at least... dom_tree_to_timespec.
17:30:50 <lmat> jralls: I did that once (KVP knows about time64 distinct from int64_t or whatever). I think it involved an empty struct? struct time64 : public int64_t {}; ...I don't remember.
17:31:12 <lmat> jralls: maybe a typedef is enough?
17:31:19 <lmat> oh, no, I don't think it is.
17:32:35 <jralls> lmat: Not if you want the type system to enforce it. An empty struct is an interesting idea, but I'm not sure that would necessarily outsmart the compiler.
17:42:59 <jralls> lmat: As for timespec nanoseconds in XML files, we create a "ts:ns" elsement if tv_nsec > 0, but nothing in our code ever puts anything but 0 into tv_nsec.
17:44:29 <jralls> lmat: So no need to write code ignoring something that's not there.
17:45:41 *** Mechtilde has quit IRC
17:48:04 *** hoijui has quit IRC
18:12:36 *** gjanssens_afk has quit IRC
18:15:59 *** User has quit IRC
18:16:05 *** User has joined #gnucash
18:46:22 *** frakturfreak has quit IRC
19:39:03 *** fekepp has quit IRC
19:57:02 *** pilotauto has joined #gnucash
20:06:49 <jralls> @tell chris Have you run tests on your time64-ftw work? I'm getting failures in test-category-report, test-standard-net-barchart, and test-standard-net-linechart.
20:06:49 <gncbot> jralls: The operation succeeded.
20:19:22 *** ArtGravity has quit IRC
21:06:06 *** User has quit IRC
22:59:56 *** sborman has quit IRC
23:04:45 *** wget has quit IRC
23:05:21 *** wget has joined #gnucash