2017-11-02 GnuCash IRC logs
00:53:49 *** meb has quit IRC
01:46:17 *** Mechtilde has joined #gnucash
01:51:30 *** Mechtilde has quit IRC
01:57:40 *** Mechtilde has joined #gnucash
02:41:50 *** Mechtilde has quit IRC
02:48:42 *** carwynnelson has joined #gnucash
02:51:51 *** carwynnelson has quit IRC
03:12:29 *** meb has joined #gnucash
03:55:51 *** fekepp has joined #gnucash
04:06:03 *** gjanssens has joined #gnucash
04:06:03 *** ChanServ sets mode: +o gjanssens
04:07:20 <gjanssens> .
04:08:48 *** bertbob has quit IRC
04:19:54 *** bastianilso_ has joined #gnucash
04:21:38 *** fekepp has quit IRC
04:22:15 *** fekepp has joined #gnucash
04:23:25 *** bastianilso_ has quit IRC
04:24:40 *** bertbob has joined #gnucash
04:24:49 *** fekepp1 has joined #gnucash
04:25:16 *** fekepp has quit IRC
04:28:01 *** fekepp1 has quit IRC
04:30:07 *** fekepp has joined #gnucash
04:32:25 *** fabior has joined #gnucash
05:14:58 *** pilotauto has quit IRC
05:15:55 *** fekepp has quit IRC
05:16:52 *** fekepp has joined #gnucash
05:32:34 *** rietta has quit IRC
05:33:48 *** rietta has joined #gnucash
05:38:13 *** fekepp has quit IRC
05:38:16 *** fekepp has joined #gnucash
05:43:47 *** fekepp has quit IRC
06:10:44 *** meb has quit IRC
06:10:57 *** meb has joined #gnucash
06:21:39 *** bertbob has quit IRC
06:22:41 *** bertbob has joined #gnucash
06:36:37 *** chris has quit IRC
06:37:02 *** chris has joined #gnucash
06:42:40 *** Jimraehl1 has joined #gnucash
06:43:44 *** Jimraehl1 has quit IRC
06:58:09 *** carwynnelson has joined #gnucash
07:01:17 *** carwynnelson has quit IRC
07:20:50 *** carwynnelson has joined #gnucash
07:23:58 *** carwynnelson has quit IRC
08:06:18 *** meb has quit IRC
08:16:26 *** meb has joined #gnucash
08:18:23 *** meb has quit IRC
08:20:00 *** meb has joined #gnucash
08:22:16 *** fabior has quit IRC
08:22:33 *** meb has quit IRC
08:26:23 *** fabior has joined #gnucash
08:26:32 *** meb has joined #gnucash
08:27:10 *** fabior has quit IRC
08:29:31 *** meb has quit IRC
09:04:12 *** sefnot has quit IRC
09:52:24 *** User has joined #gnucash
10:47:01 *** mikee_ has joined #gnucash
10:48:55 *** mikee has quit IRC
11:24:52 *** mikee_ is now known as mikee
11:25:17 <mikee> @op
11:25:17 *** gncbot sets mode: +o mikee
11:32:34 <warlord> .
12:04:43 *** User has quit IRC
12:41:34 *** Trel has quit IRC
12:45:56 *** ArtGravity has joined #gnucash
12:50:27 *** Trel has joined #gnucash
12:56:49 *** meb has joined #gnucash
13:02:06 *** meb has quit IRC
13:04:22 <jralls> @tell codesmythe Given that cmake installs all the libraries and compiled scheme files under ${CMAKE_BUILD_DIR}/libs, does ADD_SCHEME_TARGET really need the eunmerations of library_dirs, module_dirs, and modules? Can't it just hard-code those to the appropriate roots and take just a dependency list?
13:04:22 <gncbot> jralls: The operation succeeded.
13:08:37 *** fabior has joined #gnucash
13:22:56 *** meb has joined #gnucash
13:26:04 *** Mechtilde has joined #gnucash
14:01:58 *** rietta has quit IRC
14:02:44 *** rietta has joined #gnucash
14:23:49 *** ArtGravity has quit IRC
14:32:50 *** User has joined #gnucash
14:37:24 *** codesmythe has joined #gnucash
14:38:11 <codesmythe> .
14:38:11 <gncbot> codesmythe: Sent 1 hour and 33 minutes ago: <jralls> Given that cmake installs all the libraries and compiled scheme files under ${CMAKE_BUILD_DIR}/libs, does ADD_SCHEME_TARGET really need the eunmerations of library_dirs, module_dirs, and modules? Can't it just hard-code those to the appropriate roots and take just a dependency list?
14:40:54 <codesmythe> jralls: I think that is fine. Originally I supported having the build directory layout mirror the source directory layout. I think that is why it's done that way. But I've taken out the source directory mirroring, so we can clean that up.
14:46:45 *** User has quit IRC
14:49:14 <jralls> codesmythe: Ah, makes sense. Related question: GNC_ADD_SCHEME_TEST doesn't add a target so there's no way to handle dependencies. In most cases you call GNC_ADD_SCHEME_TARGET and GNC_ADD_SCHEME_TARGET on the same targets. Would it make sense to add a dependencies-list parameter to add_scheme_tests and have it call add_scheme_targets so there's only one call in each CMakeLists.txt or is there a use-case for adding a test out
14:49:14 <jralls> side of a target?
14:52:24 *** Mechtilde has quit IRC
14:53:03 *** Mechtilde has joined #gnucash
14:55:36 *** fabior has quit IRC
15:11:24 <codesmythe> jralls: GNC_ADD_SCHEME_TARGET() does add a target: https://github.com/Gnucash/gnucash/blob/unstable/common/cmake_modules/GncAddSchemeTargets.cmake#L179.
15:12:31 <codesmythe> There, the target is made to depend on its compiled source file(s). In line 172, the ADD_CUSTOM_COMMAND() is given a DEPENDS clause for other dependencies
15:13:43 <jralls> codesmythe: Of course. That's not the question. GNC_ADD_SCHEME_TEST(S) doesn't, so in most cases Scheme tests are passed to both. I'm suggesting moving the call to add_scheme_targets into add_scheme_tests so that CMakeLists.txt need call only add_scheme_tests.
15:14:29 <codesmythe> GNC_ADD_SCHEME_TARGETS() is called for all scheme files and not just tests. And test have to be specifically identified via CMake's ADD_TEST(), which is what GNC_ADD_SCHEME_TEST() is doing.
15:14:56 <codesmythe> ah, misread your question.
15:15:15 <jralls> So the question is "Is there a use-case where one would want to add a scheme test without also including it in a target?" and if so then a followup "How then to tell CMake about its dependencies?".
15:16:07 *** KaiForce has joined #gnucash
15:17:27 <codesmythe> Ok, I think I understand. You'd then pass in the dependencies for the test into ADD_SCHEME_TESTS()?
15:17:34 *** fabior has joined #gnucash
15:18:08 <codesmythe> First question answer: No, I don't think there is a use case for adding a scheme test without a target.
15:19:46 <codesmythe> I am having reading comprehension issues today. :-) You've already answered my most recent question.
15:23:53 *** Mechtilde has quit IRC
15:29:11 *** frakturfreak has joined #gnucash
15:50:59 *** codesmythe has quit IRC
15:55:17 *** carwynnelson has joined #gnucash
15:57:41 *** codesmythe has joined #gnucash
16:01:19 *** codesmythe has quit IRC
16:01:30 *** codesmythe has joined #gnucash
16:06:35 *** codesmythe has quit IRC
16:26:28 *** jotrago has quit IRC
16:26:34 *** jotrago has joined #gnucash
16:41:57 *** luciano_santos has joined #gnucash
16:53:17 *** meb has quit IRC
17:02:51 *** meb has joined #gnucash
17:05:01 *** meb has quit IRC
17:07:28 *** KaiForce has quit IRC
17:29:34 *** gjanssens has quit IRC
17:33:56 *** bastianilso_ has joined #gnucash
17:34:40 *** fabior has quit IRC
17:35:28 *** meb has joined #gnucash
17:37:35 *** bastianilso_ has quit IRC