2016-06-18 GnuCash IRC logs
01:11:15 *** goodvibes has quit IRC
01:12:04 *** goodvibes has joined #gnucash
01:36:32 *** Mechtilde has joined #gnucash
02:13:28 *** gjanssens has joined #gnucash
02:13:28 *** ChanServ sets mode: +o gjanssens
03:04:53 *** Mechtilde has quit IRC
03:47:08 <mikee> oodvibes:To create a local branch to track your remote branch: git branch --track maint origin/maint
03:50:33 <mikee> oodvibes:
03:51:05 <mikee> ??
03:53:27 *** mikee_ has joined #gnucash
03:54:07 *** mikee_ has quit IRC
04:04:21 *** f8x2n3 has joined #gnucash
04:05:27 *** rubdos has joined #gnucash
04:05:33 *** f8x2n3 has left #gnucash
04:17:35 <goodvibes> mikee: Thanks. I should have done that first instead of just cloning. I have found that 'git push github maint' did what I wanted. I've no idea why wiki says: git branch -u github working-branch. Doesn't that mean create working-branch on my GitHub repo?
04:22:07 *** f8x2n3 has joined #gnucash
04:22:43 *** rubdos has quit IRC
04:23:31 *** rubdos has joined #gnucash
04:29:16 <gjanssens> goodvibes: no, that will only tell git locally you want maint to track maint in github, regadless of whether this branch exists in github or not
04:30:03 <gjanssens> Your second step (git push github maint) was needed as well to actually create the branch in github
04:30:07 *** fabior has joined #gnucash
04:31:26 * gjanssens will now go and read the origin of this thread. He's just picking up from mikee's message to use git branch --track
04:35:00 <gjanssens> goodvibes: I just read your original question. What went wrong there is the wiki pages assumes you already have created a local "working-branch"
04:35:43 <gjanssens> In your case you said you hadn't created the local maint branch yet
04:35:59 <gjanssens> git branch -u explicitly works on a local branch
04:36:07 <gjanssens> (an existing one)
04:38:07 <goodvibes> gjanssens: Hm.. I did have a local maint branch because I cloned official gnucash maint to a local maint.
04:39:39 <gjanssens> goodvibes: ok. I'm still trying to understand exactly what you did...
04:40:16 <gjanssens> So before you did "git clone <official-gnucash-repo>" followed by a "git checkout maint" at some point ?
04:40:50 <goodvibes> Is it OK for my rpt mod to go into maint? The wiki says all enhancements should go into master.
04:41:33 <gjanssens> By the policy it should go into master...
04:42:15 <gjanssens> I haven't looked at it yet, if the changes are trivial, I sometimes choose to commit to maint anyway.
04:42:42 <gjanssens> But I have been bitten by that in the past so I'm fairly conservative in this.
04:42:45 <goodvibes> I did the clone but didn't do a checkout. I only today read something that really explains what checkout does. I've not been confident enough to do a checkout but I am now.
04:43:27 <gjanssens> If you didn't do the checkout, there won't be a local maint branch, which explains why git branch -u failed
04:44:18 * gjanssens heads to github to read your PR...
04:45:35 <goodvibes> Sounds reasonable - Thanks!
04:49:51 <goodvibes> git status says: 'On branch maint' so I've been assuming I was. I did: git clone -b maint https://github.com/Gnucash/gnucash gnucash
04:51:40 <goodvibes> It's been a challenge but I've really enjoyed learning some scheme :-)
04:51:40 <gjanssens> goodvibes: interesting. I never used "-b" on git clone
04:51:58 <gjanssens> That should indeed check out your local maint branch
04:52:15 <gjanssens> and invalidate my theory so far...
04:54:12 <goodvibes> Don't worry about it - I'll try more usual branching in future.
05:00:05 <goodvibes> Any questions about PR before I go to dinner?
05:03:56 <gjanssens> Not yet. I'm still studying it. I'll make my comments directly on the PR
05:04:00 <gjanssens> Enjoy dinner :)
05:54:28 *** fabior has quit IRC
06:04:20 *** goodvibes has quit IRC
06:07:34 *** fabior has joined #gnucash
06:08:57 *** rubdos has quit IRC
06:09:21 *** rubdos has joined #gnucash
06:37:35 *** uXuss has quit IRC
06:43:29 *** uXuss has joined #gnucash
06:56:32 *** mlncn has quit IRC
07:02:29 *** fabior has quit IRC
08:02:39 *** fabior has joined #gnucash
08:43:53 *** andy has quit IRC
08:59:47 *** andy has joined #gnucash
09:13:14 *** gjanssens has quit IRC
11:23:46 *** fabior has quit IRC
11:34:56 *** gjanssens has joined #gnucash
11:34:56 *** ChanServ sets mode: +o gjanssens
11:38:16 *** fabior has joined #gnucash
12:46:08 *** gjanssens has quit IRC
12:48:45 *** gjanssens has joined #gnucash
12:48:45 *** ChanServ sets mode: +o gjanssens
13:01:00 *** fabior has quit IRC
13:03:28 *** aqua___ has joined #gnucash
13:06:33 *** aqua___ has quit IRC
13:15:25 *** f8x2n3 has quit IRC
13:15:59 *** fabior has joined #gnucash
13:17:02 *** f8x2n3 has joined #gnucash
13:17:44 *** gjanssens has quit IRC
13:20:56 *** aqua___ has joined #gnucash
13:23:48 *** fabior has quit IRC
15:00:32 *** aqua___ has quit IRC
15:16:50 *** aqua___ has joined #gnucash
16:11:42 *** Mechtilde has joined #gnucash
17:09:10 *** Mechtilde has quit IRC
17:42:08 *** f8x2n3 has quit IRC
17:53:54 *** aqua___ has quit IRC
17:56:30 *** minot has joined #gnucash
18:33:37 *** kael has joined #gnucash
18:54:59 *** minot has quit IRC
20:31:11 *** kael has quit IRC
21:29:09 *** kael has joined #gnucash
22:01:48 *** kael has quit IRC
23:24:55 *** warlord has joined #gnucash
23:24:56 *** gncbot sets mode: +o warlord