2016-05-23 GnuCash IRC logs

00:09:43 *** warlord has joined #gnucash
00:15:45 *** bertbob has joined #gnucash
00:40:49 *** CDB-Man has quit IRC
00:44:44 *** puck has quit IRC
00:49:41 *** puck has joined #gnucash
00:57:57 *** CDB-Man has joined #gnucash
01:02:24 *** CDB-Man has quit IRC
01:02:35 *** CDB-Man has joined #gnucash
01:28:53 *** Mechtilde has joined #gnucash
01:51:22 *** warlord has quit IRC
02:06:21 *** Mechtilde has quit IRC
03:08:59 *** mlncn has quit IRC
03:20:32 *** fell has joined #gnucash
04:06:27 *** uXuss has quit IRC
04:07:08 *** nomeata has joined #gnucash
04:09:54 *** uXuss has joined #gnucash
04:30:48 *** bozonius has quit IRC
04:33:11 *** uXusss has joined #gnucash
04:34:05 *** uXusss has quit IRC
04:51:44 *** fabior has joined #gnucash
05:05:27 *** fabior has quit IRC
05:11:50 *** bozonius has joined #gnucash
05:19:55 *** fabior has joined #gnucash
06:01:06 *** fabior has quit IRC
06:20:35 *** fabior has joined #gnucash
06:29:09 *** Jimraehl1 has left #gnucash
06:55:55 *** mlncn has joined #gnucash
07:13:35 *** fabior has quit IRC
07:27:09 *** Jimraehl1 has joined #gnucash
07:46:58 *** wget_ has joined #gnucash
07:47:01 *** wget has quit IRC
08:10:18 *** fell_ has joined #gnucash
08:12:29 *** fell has quit IRC
08:26:12 *** fabior has joined #gnucash
08:29:52 *** fabior has quit IRC
08:30:14 *** fabior has joined #gnucash
08:44:01 *** minot has joined #gnucash
08:57:17 <lmat> jchonig: it's jralls :-) You can leave a note for him by using @note jralls <note> or something like that.
08:59:44 *** andy has quit IRC
09:00:03 *** andy has joined #gnucash
09:03:54 <lmat> jralls: It's not getting a DST for a timezone in a year. The function is attempting to fetch a TZ_Ptr for a year. In the case that one isn't found, should we return UTC?
09:07:45 *** andy has quit IRC
09:08:22 *** andy has joined #gnucash
09:10:48 *** andy has quit IRC
09:20:50 *** andy has joined #gnucash
09:36:13 <jchonig> lmat thanks
09:36:35 *** wget_ has quit IRC
09:49:39 *** minot has quit IRC
09:51:31 *** minot has joined #gnucash
10:14:12 *** wget has joined #gnucash
10:28:14 *** aqua___ has joined #gnucash
10:31:20 *** aqua___ has quit IRC
10:38:32 *** hoijui has joined #gnucash
10:45:28 *** aqua___ has joined #gnucash
10:51:25 <lmat> @tell jchonig hello
10:51:25 <gncbot> lmat: The operation succeeded.
10:51:29 <lmat> that's it...
11:06:48 *** nomeata has quit IRC
11:35:26 <jralls> lmat: Right, but *why* does it not get a TZ_ptr?
11:48:06 *** Mechtilde has joined #gnucash
11:56:32 *** bertbob has quit IRC
11:58:42 *** Mechtilde has quit IRC
12:11:48 *** bertbob has joined #gnucash
12:14:49 *** bertbob has quit IRC
12:27:31 *** fabior has quit IRC
12:28:50 *** bertbob has joined #gnucash
12:32:44 *** hoijui has quit IRC
12:36:07 *** CDB-Man_ has joined #gnucash
12:36:54 *** CDB-Man has quit IRC
12:42:12 *** fabior has joined #gnucash
12:59:59 *** fabior has quit IRC
13:00:58 *** Mechtilde has joined #gnucash
13:05:21 *** minot has quit IRC
13:22:32 *** aqua___ has quit IRC
13:26:57 *** fabior has joined #gnucash
13:36:37 *** aqua___ has joined #gnucash
14:02:25 *** fabior has quit IRC
14:05:50 <jralls> lmat: We need a C++ API for GncGUID. Can you do that?
14:12:30 *** CDB-Man has joined #gnucash
14:13:49 <lmat> jralls: Sorry for the delay. Why does what not get a TZ_ptr? Are you asking why one wouldn't be present for a given year?
14:14:10 *** CDB-Man_ has quit IRC
14:18:47 <lmat> jralls: Yes. GncGUID is a boost::uuids::uuid, so that should be in a header file so that c++ code doesn't have to cast or guess, and the header file should expose the gnucash-specific guid methods in a C++ way. Is that along the lines you're thinking?
14:21:10 <jralls> lmat: 1st, TimeZoneProvider::Get(). 2nd, yes, exactly.
14:22:23 <jralls> lmat: Second case came because I'm reviewing Robert Ferell's import-bayes -> C++ work and he has to use the GncGUID C interface because there isn't a C++ one.
14:24:00 <jralls> lmat: First case: Wow, that was incredibly brain-dead of me, to throw 5 lines below a noexcept decl. Still amazed that most compilers aren't catching that. What version did?
14:26:13 <lmat> jralls: I'm not sure how the time zones are populated, so I don't know why a timezone provider wouldn't have a timezone for a particular year.
14:26:56 <lmat> jralls: This all compiled (and unit tests passed) a week ago for me, so I think gcc < 6 didn't check? I'm happy it's checking -- better late than never -- but it's really lat.
14:27:02 *** bertbob has quit IRC
14:27:51 <jralls> Right, and the lack of a TZ isn't necessarily happening, of course, it's just the compiler complaining about my stupidity... Except that I think it did happen to somebody.
14:28:28 *** Mechtilde has quit IRC
14:31:42 <jralls> The Unix TZP constructor creates a max_date entry in the vector, but I think perhaps the Windows one doesn't. I'll fix that if it's true. I think rather than a nullptr TZP::get() should return a NoDST TZ for the correct offset if possible and a UTC one if not. Either way it needs to log the error.
14:33:41 <lmat> jralls: For logging, we're still looking at PWARN or so, right?
14:34:08 <jralls> No, I think that it warrants a PERR.
14:35:12 <lmat> jralls: Sure, I was asking about the library; I agree PERR. I have a Pull Request published. I can update it with this information.
14:35:14 <jralls> And I see the problem, in TZP::load_windows_classic_tz. Two problems, in fact: It uses 0 for the year and that's less than min_year and anyway it should be max_year.
14:36:40 *** aqua___ has quit IRC
14:37:00 <lmat> jralls: Oh no... gcc 6.1.1 throws an error due to misleading-indentation :-(
14:37:21 <lmat> gnc-backend-sql.cpp:1653
14:37:42 <lmat> "...this statement, but the latter is misleadingly indented as if it is guarded by the if"
14:39:49 <jralls> On Github it looks like it's indented as if it's *not* protected by the if.
14:41:23 <jralls> And then 1655 looks like it's protected by if(QOF_IS_INSTANCE).
14:41:32 <lmat> jralls: It says that the if on 1653 does not guard 1655.
14:43:02 *** bertbob has joined #gnucash
14:44:57 <jralls> Ah, and I agree. Anyway you can either clean it up or disable the warning. Or I can merge 9204a99b from c++-backend which runs astyle on the whole mess. That's probably the best option.
14:49:54 <lmat> b36a21d?
14:50:21 <lmat> OOps, I was out of date :-)
14:50:27 <lmat> yes, 9204a99
14:50:42 *** aqua___ has joined #gnucash
14:55:03 <jralls> The sha will change again, because I'm doing another maint->master merge and then I'll rebase c++-backend onto master (which will change the sha) before merging, all to keep everything linear.
14:55:26 <lmat> yup.
14:59:35 *** hoijui has joined #gnucash
14:59:51 *** JFS has left #gnucash
15:06:29 *** hoijui has quit IRC
15:07:07 *** hoijui has joined #gnucash
15:08:04 <jchonig> jralls Hi
15:08:04 <gncbot> jchonig: Sent 4 hours and 16 minutes ago: <lmat> hello
15:08:21 <jralls> Hello, jchonig.
15:08:57 <jchonig> jralls Thanks for your help on that bug. Is there any reason that I need to restore those %formula entries? I can easily recreate my three SX
15:10:50 <jralls> jchonig: You could just do the UPDATE query to disable all of the SXes and then from the SX Editor delete them if you'd rather do that than restore from backup.
15:11:15 <jchonig> jralls much easier if there is no reason to restore from backup.
15:12:28 <jchonig> jralls Also, on compiling from source, I did read and follow the FAQ, but there are various deb dependencies preventing getting all the required packages at the right versions.
15:14:35 <jralls> jchonig: That's odd. With the exception of GOffice GnuCash should be happy with whatever versions are installed, just hand-install the respective dev packages. GOffice needs to be at 0.8, anything newer requires gtk+3.
15:15:36 *** mlncn has quit IRC
15:16:26 <jchonig> jralls something had a specific version and a later was installed. It's a job for a clean docker container....
15:17:09 <jralls> Like I said, unless it's GOffice, no worries.
15:25:53 *** bertbob has quit IRC
15:33:53 *** fabior has joined #gnucash
15:40:59 *** bozonius has quit IRC
15:41:34 *** bertbob has joined #gnucash
15:44:42 *** bertbob has quit IRC
15:55:26 *** bozonius has joined #gnucash
16:00:17 *** bertbob has joined #gnucash
16:22:53 <jralls> lmat: Heh, Bob Fewell had already fixed load_windows_classic_tz 2 1/2 weeks ago. Guess I hadn't refreshed the github view in the meantime.
16:24:58 <lmat> jralls: Well that's convenient.
16:25:57 <jralls> lmat: I had a testing issue with boost_regex thanks to it not setting install_name correctly. running final make check now... done, and pushed.
16:27:30 *** mlncn has joined #gnucash
16:30:55 <jralls> lmat: So do you want to redo your PR or shall I just do the necessary fix and push it?
16:40:52 *** mlncn has quit IRC
16:40:56 *** aqua___ has quit IRC
16:49:39 <lmat> jralls: I'll cancel the PR.
16:49:55 <jralls> OK.
16:53:30 <lmat> jralls: Thanks for pushing the session stuff to master, too.
16:56:46 <jralls> Session stuff?
17:00:32 <lmat> jralls: 915a2930 I think was just pushed to master...checking
17:01:22 <jralls> Oh, yes. That was really a backend change that bled into session a bit.
17:21:06 *** hoijui has quit IRC
18:04:13 *** fabior has quit IRC
18:20:38 *** mlncn has joined #gnucash
18:24:26 *** mlncn has quit IRC
18:41:04 *** mlncn has joined #gnucash
18:44:18 *** mlncn has quit IRC
18:45:31 *** mlncn has joined #gnucash
18:53:06 *** mlncn_ has joined #gnucash
18:53:27 *** mlncn has quit IRC
19:04:30 *** mlncn__ has joined #gnucash
19:05:28 *** mlncn_ has quit IRC
19:05:54 *** CDB-Man_ has joined #gnucash
19:06:38 *** CDB-Man has quit IRC
19:17:25 *** GabrieleV has quit IRC
19:33:04 *** mlncn__ has quit IRC
19:50:37 *** CDB-Man has joined #gnucash
19:52:00 *** CDB-Man_ has quit IRC
20:24:33 *** GabrieleV has joined #gnucash
22:05:01 *** CDB-Man_ has joined #gnucash
22:05:46 *** CDB-Man has quit IRC
23:06:24 *** fell_ has quit IRC
23:36:59 *** fell has joined #gnucash